Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(esp_modem_usb_dte): add esp32p4 support & add cat.4 ec20 modem #30

Closed

Conversation

leeebo
Copy link
Collaborator

@leeebo leeebo commented Apr 22, 2024

As esp32p4 has been supported in usb_host_cdc_acm, it should be the right time for us to support higher throughput Cat.4 Cellular module (DL 150 Mbps, UL 50 Mbps).

Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leeebo Thank you for the update!

There is one outstanding issue for some USB modems on P4. Sometimes the esp_modem tries to append received data to USB data buffer, which causes error with unaligned cache sync.

We can merge it now and I can fix it later, what do you think?

host/class/cdc/esp_modem_usb_dte/CMakeLists.txt Outdated Show resolved Hide resolved
@leeebo leeebo force-pushed the feat/modem_usb_dte_support_esp32p4 branch from 25022bb to 32e647a Compare June 5, 2024 11:20
@david-cermak
Copy link
Contributor

There is one outstanding issue for some USB modems on P4. Sometimes the esp_modem tries to append received data to USB data buffer, which causes error with unaligned cache sync.

@leeebo @tore-espressif Do you think it's happening only on P4? Probably not the cache sync issue, but maybe those "appended fragments" getting lost?
I hear there're still some stability issues when using USB with esp_modem (compared to UART), the latest is here espressif/esp-protocols#589

@tore-espressif
Copy link
Collaborator

This particular issue is only relevant for P4.

I can check the issue you linked, but no sooner then end of this month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants