Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade CD pipeline #5022

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Upgrade CD pipeline #5022

merged 2 commits into from
Jan 13, 2025

Conversation

jngrad
Copy link
Member

@jngrad jngrad commented Dec 20, 2024

Description of changes:

  • update continuous delivery (CD) pipeline to download CI artifacts through the GitLab REST API
  • properly document and install all required dependencies of the CD pipeline
    • the new Ubuntu 24.04 runner comes with fewer pre-installed depdendencies
  • move action script to a self-contained shell script
    • simplify maintenance work with tools like shellcheck
  • print fully expanded shell commands before executing them to help diagnose issues with cloud services

@jngrad jngrad added the DevOps label Dec 20, 2024
@jngrad jngrad requested a review from reinaual December 20, 2024 16:12
RudolfWeeber
RudolfWeeber previously approved these changes Jan 7, 2025
Copy link
Contributor

@RudolfWeeber RudolfWeeber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you pls add in some comments, e.g., where project id magic number comes form and what the jq calls do?

@jngrad
Copy link
Member Author

jngrad commented Jan 7, 2025

project id magic number

That's the number associated with our GitLab espressomd/espresso repository. You can read this number from the project settings or in the drop-down menu that appears when clicking on the button with three black dots labeled "More actions". This is a unique number that even admins cannot modify. The uri projects/390 automatically redirects to the project.

@jngrad jngrad requested a review from RudolfWeeber January 9, 2025 20:40
@jngrad jngrad added the automerge Merge with kodiak label Jan 13, 2025
@kodiakhq kodiakhq bot merged commit ba9d026 into espressomd:python Jan 13, 2025
10 checks passed
@jngrad jngrad deleted the gh_pages branch January 13, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge with kodiak DevOps
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants