E_showMenu_F18/Q3: Remove internal menu object l as argument to callback function
#2569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove internal menu object `l` as argument to callback function. This removes a potential for memory leaks and should otherwise have no impact. As no app on the main BangleApps repo seems to use the option. See espruino#2567. closes espruino#2567
thyttan
force-pushed
the
showmenu-q3-remove-scroller-as-callback-argument
branch
from
fb6f833 to
a49add7
Compare
thyttan
changed the title
thyttan
changed the title
l as argument to callback function
|
Great - thanks for checking! |
gfwilliams
added a commit
to espruino/EspruinoDocs
that referenced
this pull request
Oct 11, 2024
gfwilliams
added a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a potential for memory leaks and should otherwise have no impact. As no app on the main BangleApps repo seems to use the option. See #2567.
closes #2567