removing noqas as file is now imported through conftest

ess-dmsc · Mar 11, 2020 · 9800fad · 9800fad
1 parent e7bb719
commit 9800fad
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 13 deletions.
diff --git a/.flake8 b/.flake8
@@ -6,7 +6,4 @@ select = B,C,E,F,W,T4,B9
 exclude = ui/,build*,definitions
 per-file-ignores =
     nexus_constructor/geometry/__init__.py:F401
-    tests/test_json_writer.py:F811
-    tests/ui_tests/test_stream_fields_widget.py:F811
-    tests/ui_tests/test_ui_field_attrs.py:F811
     tests/ui_tests/test_ui_fields.py:F811,F401
diff --git a/tests/test_instrument.py b/tests/test_instrument.py
@@ -71,7 +71,7 @@ def test_GIVEN_instrument_with_component_WHEN_component_is_removed_THEN_componen
     )
 
 
-def test_dependents_list_is_created_by_instrument(file, nexus_wrapper):  # noqa: F811
+def test_dependents_list_is_created_by_instrument(file, nexus_wrapper):
     """
     The dependents list for transforms is stored in the "dependent_of" attribute,
     which is not part of the NeXus standard,
@@ -109,7 +109,7 @@ def test_dependents_list_is_created_by_instrument(file, nexus_wrapper):  # noqa:
 
 
 def test_dependent_is_created_by_instrument_if_depends_on_is_relative(
-    file, nexus_wrapper  # noqa: F811
+    file, nexus_wrapper
 ):
     entry_group = file.create_group("entry")
     entry_group.attrs["NX_class"] = "NXentry"
@@ -130,7 +130,7 @@ def test_dependent_is_created_by_instrument_if_depends_on_is_relative(
 
 
 def test_dependee_of_contains_both_components_when_generating_dependee_of_chain_with_mixture_of_absolute_and_relative_paths(
-    file, nexus_wrapper  # noqa: F811
+    file, nexus_wrapper
 ):
     entry_group = file.create_group("entry")
     entry_group.attrs["NX_class"] = "NXentry"

diff --git a/tests/test_transformations.py b/tests/test_transformations.py
@@ -488,7 +488,7 @@ def test_GIVEN_nexus_file_with_linked_transformation_but_without_dependee_of_att
 
 
 def test_GIVEN_transformation_with_scalar_value_that_is_not_castable_to_int_WHEN_getting_ui_value_THEN_ui_placeholder_value_is_returned_instead(
-    file, nexus_wrapper  # noqa: F811
+    file, nexus_wrapper
 ):
     transform_name = "transform_1"
     transform = create_transform(nexus_wrapper, transform_name)
@@ -501,7 +501,7 @@ def test_GIVEN_transformation_with_scalar_value_that_is_not_castable_to_int_WHEN
 
 
 def test_multiple_relative_transform_paths_are_converted_to_absolute_path_in_dependee_of_field(
-    file, nexus_wrapper  # noqa: F811
+    file, nexus_wrapper
 ):
     component_name = "component_1"
 
@@ -540,9 +540,7 @@ def test_multiple_relative_transform_paths_are_converted_to_absolute_path_in_dep
     )
 
 
-def test_transforms_with_no_dependees_return_None_for_depends_on(
-    file, nexus_wrapper
-):  # noqa: F811
+def test_transforms_with_no_dependees_return_None_for_depends_on(file, nexus_wrapper):
     component_name = "component_1"
 
     component1 = add_component_to_file(nexus_wrapper, component_name=component_name)

diff --git a/tests/ui_tests/test_ui_transformation_view.py b/tests/ui_tests/test_ui_transformation_view.py
@@ -66,7 +66,7 @@ def test_UI_GIVEN_scalar_angle_WHEN_creating_rotation_view_THEN_ui_is_filled_cor
 
 
 def test_UI_GIVEN_array_dataset_as_magnitude_WHEN_creating_translation_THEN_ui_is_filled_correctly(
-    qtbot, file, nexus_wrapper  # noqa:F811
+    qtbot, file, nexus_wrapper
 ):
     instrument = Instrument(nexus_wrapper, {})
 
@@ -94,7 +94,7 @@ def test_UI_GIVEN_array_dataset_as_magnitude_WHEN_creating_translation_THEN_ui_i
 
 
 def test_UI_GIVEN_stream_group_as_angle_WHEN_creating_rotation_THEN_ui_is_filled_correctly(
-    qtbot, file, nexus_wrapper  # noqa:F811
+    qtbot, file, nexus_wrapper
 ):
     instrument = Instrument(nexus_wrapper, {})