Merge pull request #680 from ess-dmsc/679_edit_component_on_transform…

…ation 679 - Disabling edit component button when transformation is selected
ess-dmsc · Mar 13, 2020 · cca2343 · cca2343
2 parents 2d4dac0 + a6c5768
commit cca2343
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/nexus_constructor/treeview_utils.py b/nexus_constructor/treeview_utils.py
@@ -78,14 +78,14 @@ def set_button_states(
         )
     else:
         selected_object = selection_indices[0].internalPointer()
-
-        zoom_action.setEnabled(isinstance(selected_object, Component))
+        selected_object_is_component = isinstance(selected_object, Component)
+        zoom_action.setEnabled(selected_object_is_component)
 
         selected_object_is_component_or_transform = isinstance(
             selected_object, (Component, Transformation)
         )
         duplicate_action.setEnabled(selected_object_is_component_or_transform)
-        edit_component_action.setEnabled(selected_object_is_component_or_transform)
+        edit_component_action.setEnabled(selected_object_is_component)
 
         selected_object_is_not_link_transform = not isinstance(
             selected_object, LinkTransformation

diff --git a/tests/ui_tests/test_main_window_utils.py b/tests/ui_tests/test_main_window_utils.py
@@ -348,7 +348,6 @@ def test_GIVEN_transformation_is_selected_WHEN_changing_button_states_THEN_expec
     transformation_selected_actions = {
         delete_action,
         duplicate_action,
-        edit_component_action,
         new_rotation_action,
         new_translation_action,
         create_link_action,