This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
fixed translation issue #1041
Merged
fixed translation issue #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
ECDC-3621: this branch fixes the first part of this issue, introduced in commit 7c1d072, preceeded by 5e89859 which works, https://github.com/ess-dmsc/nexus-constructor/compare/5e89859..7c1d072e and allows for further development in other related tickets. It does not fix and does PR does not aim to fix other issues raised in this ticket.
Description of work
component.py:90 contains an empty list, which does not have NoneType
There are many statements that utilise the stored_transforms variable which are (and the object itself checked) for None. We do not need to check for None (an empty object evaluates the same) but there are too many to be able to apply this 'better' fix as confidently as this one-line commit.
Acceptance Criteria
'Correctly'-functioning codebase
UI tests
No additional UI test has been included. User should test manually to add a component with a translation and see that the object moves immediately when a magnitude is assigned
Nominate for Group Code Review