add dhl dimensions validation

esteit · Dec 3, 2015 · dc34b02 · dc34b02
1 parent 2ced302
commit dc34b02
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/CalculatorHandler/DhlCalculatorHandler.php b/src/CalculatorHandler/DhlCalculatorHandler.php
@@ -151,6 +151,10 @@ public function validateDimensions(PackageInterface $package)
         $maxDimensions = $this->normalizeDimensions($this->get('maximum_dimensions'));
         $dimensions = $this->normalizeDimensions($package->getDimensions());
 
+        if (!$dimensions->getHeight() || !$dimensions->getLength() || !$dimensions->getWidth()) {
+            throw new InvalidDimensionsException('Dimensions must be greater than zero.');
+        }
+
         $maxLength = $converter->convert($maxDimensions->getLength(), $this->get('dimensions_unit'), $dimensions->getUnit());
         if ($math->greaterThan($dimensions->getLength(), $maxLength)) {
             throw new InvalidDimensionsException('Dimensions limit is exceeded.');