honor CLICOLOR and CLICOLOR_FORCE

[lelongg]

add support of CLICOLOR to disable color output and CLICOLOR_FORCE to force color output

See https://bixense.com/clicolors/

[Miuler]

resolve #307

[bconn98]

@lelongg Are you able to resolve the conflicts on this branch?

[lelongg]

it is resolved

[bconn98]

@estk Recommend this MR to control color vs no color. Using ENV vars is more standardized than a configuration flag recommended by #305.

[estk]

@lelongg excellent work.
@bconn98 I think both could be helpful but lets see if this works well enough to satisfy the author of #305. As always thanks again for your help.

@lelongg

1. Regarding the failing test, it'd be great to have a solution for windows, but if not no worries feel free to either shut up clippy or #cfg(not(windows)) the var.
2. Can we also implement NO_COLOR? If not no worries.
3. Can you write tests for this (impl is excellent and simple, but it'll keep us from breaking things in the future.)

[lelongg]

I submitted points 1 and 2. About the tests I'm not sure how to handle this, I didn't find examples of tests checking the logs output in the code, can you help ?

[estk]

No problem, I would create a new example in the examples dir that utilizes (or does not utilize) the feature.
Then create an integration test (in /test) that uses std::process::Command to run the example.
Finally you will verify its output is as you expect.

[codecov-commenter]

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (58b92c8) 61.12% compared to head (b536024) 60.81%.

Files	Patch %	Lines
src/encode/writer/console.rs	39.28%	17 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   61.12%   60.81%   -0.32%     
==========================================
  Files          23       23              
  Lines        1407     1429      +22     
==========================================
+ Hits          860      869       +9     
- Misses        547      560      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bconn98]

@lelongg Take a look at my branch #335 which makes the changes for windows. I'm not sure the right way to test this in the CI though (or in windows). I tested the linux version running locally but I don't have a windows env to test in. I didn't take @estk's suggestion on the integration example with std::process yet, instead I took the lazy way out in the CI.

[bconn98]

Interesting, I swapped over to a new test using exe. It works fine locally but weird results in the CI, but CLICOLOR_FORCE works!

[bconn98]

@lelongg Looks like #335 was merged in. If you're happy with the changes, please close the PR.