-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation covering all current aspects of the configuration file #308
Conversation
Thank you @bconn98 |
Thanks 👍🏻 |
Hey @estk It's been a while since I've seen a PR approved, I don't see much activity. What are the plans to approve this PR and the others pending review? |
Thank you very much, I really think this is a very good library with lot's of potential to be even better. |
@bconn98 thanks so much for your work on this. I have a couple procedural comments:
Thanks so much! |
@estk Thanks for the comments. Should be all set. Looks like the workflows need approved prior to executing though. |
@bconn98 looking good, can you split out the markdown lint to a separate CI job? You'll also need to bump the minimum rust version in the CI to 1.57 |
@estk ✅ and ✅ |
seems like there is a rustfmt issue. |
@estk 👍 actually ran the linters locally so should be good for both MD's and the rustfmt |
Looks like there are version issues. I'll fight these tomorrow. |
fwiw im open to moving to 1.60 as a minimum but let split that into a sep PR |
alright, i think we're in the home stretch. Can you also replace the configuration section with a link to the config page and dedupe the text in the first para? |
🎉 |
Add a markdown document detailing all the configuration options provided by log4rs.
Fixes: #291
Fixes: #304
Fixes: #306