dekaf: Introduce IDLE_SESSION_TIMEOUT to allow configuring the idle session timeout
#1773
Conversation
jshearer
changed the title
IDLE_SESSION_TIMEOUT_MS to allow configuring the idle session timeoutIDLE_SESSION_TIMEOUT to allow configuring the idle session timeout
jshearer
force-pushed
the
dekaf/configurable_timeout
branch
2 times, most recently
from
5ef5d67
to
f3a0f73
Compare
… session timeout
jshearer
force-pushed
the
dekaf/configurable_timeout
branch
from
f3a0f73
to
ad8683e
Compare
| @@ -27,6 +27,7 @@ axum = { workspace = true } | |||
| axum-extra = { workspace = true } | |||
| axum-server = { workspace = true } | |||
| base64 = { workspace = true } | |||
| humantime = { workspace = true } | |||
There was a problem hiding this comment.
Given that we use Go's ParseDuration in all other places I know of, maybe we should use https://docs.rs/go-parse-duration/latest/go_parse_duration/
Thoughts? @williamhbaker @jgraettinger @psFried
There was a problem hiding this comment.
We've been using humantime for a while for this, I think we should stick with it
There was a problem hiding this comment.
Looks like humantime's parse_duration supports:
nsec, ns – nanoseconds
usec, us – microseconds
msec, ms – milliseconds
seconds, second, sec, s
minutes, minute, min, m
hours, hour, hr, h
days, day, d
weeks, week, w
months, month, M – defined as 30.44 days
years, year, y – defined as 365.25 days
And go-parse-duration says:
Valid time units are “ns”, “us” (or “µs”), “ms”, “s”, “m”, “h”.
So humantime supports a superset of the time units that go-parse-duration does... I'd say this is good?
Introducing this because I want to see if raising the session timeout resolves issues with static consumer group memberships.
This change is