agent: combine regular failed publications in status history #1792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the publication history in the controller status. We already reduced consecutive touch publications in the history. This is important because it prevents touch publications, which can sometimes number in the hundreds per day, from quickly pushing out other relevant information from the publication history. But it turns out there's another case where repeated publications can clog up the history. This happens from repeated regular (non-touch) build failures, since we retry them indefinitely. Previously, the rule was that we'd never combine non-touch publications. The goal was to make sure that we always show distinct history entries for publications that modify the model. This tweaks that rule so that we will combine _unsucessful_ non-touch publications. The result is that the publications history in the status remains a lot more readable and useful when there are repeated auto-discover publication failures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the publication history in the controller status. We already reduced consecutive touch publications in the history. This is important because it prevents touch publications, which can sometimes number in the hundreds per day, from quickly pushing out other relevant information from the publication history. But it turns out there's another case where repeated publications can clog up the history. This happens from repeated build failures, since we retry them indefinitely.
Previously, the rule was that we'd never combine non-touch publications. The goal was to make sure that we always show distinct history entries for publications that modify the model. This tweaks that rule so that we will combine unsuccessful non-touch publications. The result is that the publications history in the status remains a lot more readable and useful when there are repeated auto-discover publication failures.
This change is