Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es_extended/client): add vehicle type to ESX.Game.GetVehicleProp… #1583

Closed
wants to merge 1 commit into from

Conversation

someone005
Copy link
Contributor

Description

This PR adds vehicle type to ESX.Game.GetVehicleProperties return table.


Motivation

Developers won't have to manually add vehicle type to properties table.


PR Checklist

  • [ x ] My commit messages and PR title follow the Conventional Commits standard.
  • [ x ] My changes have been tested locally and function as expected.
  • [ x ] My PR does not introduce any breaking changes.
  • [ x ] I have provided a clear explanation of what my PR does, including the reasoning behind the changes and any relevant context.

@Mycroft-Studios
Copy link
Member

why would you need type?

@someone005
Copy link
Contributor Author

why would you need type?

For example, developer saves vehicle properties in database and next wants to create vehicle using CreateVehicleServerSetter. He can take type from properties without manually putting them in properties table. I don't think it important thing but ig that some developers would like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Recycle Bin
Development

Successfully merging this pull request may close these issues.

2 participants