stick a bit more to the siri spec #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoine-de
force-pushed
the
more_fields
branch
from
4f3b0c3 to
e75bb0a
Compare
Tristramg
reviewed
Feb 13, 2019
src/routes/stop_monitoring.rs
Outdated
| .get_corresponding_from_idx(connection.dated_vj.vj_idx) | ||
| .into_iter() | ||
| .next(); | ||
| let operator_ref = operator_idx.map(|idx| data.ntm.companies[idx].id.clone()); |
There was a problem hiding this comment.
why not chain the map directly, instead of storing the index?
src/routes/stop_monitoring.rs
Outdated
| start_time: chrono::NaiveDateTime, | ||
| duration: &Option<utils::Duration>, | ||
| ) -> bool { | ||
| if let Some(duration) = duration { |
There was a problem hiding this comment.
wouldn’t a map_or be clearer ? at least a match
antoine-de
force-pushed
the
more_fields
branch
from
e75bb0a to
cb53350
Compare
antoine-de
force-pushed
the
more_fields
branch
from
cb53350 to
d3a91a7
Compare
Tristramg
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add 2 filters:
fill the field operator_ref
I updated #19 with the remaining params