Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

++Support /app, -+next/router to next/navigation #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

++Support /app, -+next/router to next/navigation #79

wants to merge 1 commit into from

Conversation

karthi-21
Copy link

Fixing issue #78

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@karthi-21 karthi-21 changed the title -+next/router tp next/navigation ++Support /app, -+next/router to next/navigation Jul 12, 2023
gavmck
gavmck previously approved these changes Jan 30, 2024
View reviewed changes
gavmck
gavmck reviewed Jan 30, 2024
View reviewed changes
Copy link
Member

@gavmck gavmck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break if it's used in /pages?

@gavmck gavmck self-requested a review January 30, 2024 09:50
@JoshTheWanderer JoshTheWanderer dismissed gavmck’s stale review January 31, 2024 15:57

awaiting clarification

@JoshTheWanderer JoshTheWanderer added the question Further information is requested label Jan 31, 2024
@ahummel25
Copy link

Hi @karthi-21, any movement on this?

Thanks!

@karthi-21
Copy link
Author

karthi-21 commented Mar 18, 2024 •
edited
Loading

Sry for the late reply, YES this change is specific to app directory. This might not work for pages directory.

https://nextjs.org/docs/app/building-your-application/routing/linking-and-navigating#userouter-hook

https://stackoverflow.com/questions/76285831/whats-the-difference-between-next-router-and-next-navigation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavmck gavmck Awaiting requested review from gavmck

At least 1 approving review is required to merge this pull request.

Assignees

@karthi-21 karthi-21

Labels
question Further information is requested
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthi-21 @ahummel25 @gavmck @JoshTheWanderer