Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/eth_getBlockByNumber and eth_getUncle... nullable fields #341

Merged
merged 22 commits into from
Mar 29, 2021
Merged

Fix/eth_getBlockByNumber and eth_getUncle... nullable fields #341

merged 22 commits into from
Mar 29, 2021

Commits on Mar 15, 2021

  1. ethclient,internal/ethapi: add Nonce (null) to pending block JSON 

    Date: 2021-03-15 09:53:13-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    418e29f View commit details
    Browse the repository at this point in the history

  2. ethclient: add test case for expected non-null values ('number') 

    Date: 2021-03-15 09:56:24-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    be15ecb View commit details
    Browse the repository at this point in the history

  3. ethclient: refactor test, unifying to map of expected value (null, ze… 

    …ro-value, and filled)

Date: 2021-03-15 10:07:04-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    b446973 View commit details
    Browse the repository at this point in the history

  4. ethclient: add missing fields to test and compare diff 

    Date: 2021-03-15 10:15:24-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    dc4e75c View commit details
    Browse the repository at this point in the history

  5. ethclient,internal/ethapi: add Hash (null) to pending block JSON 

    Date: 2021-03-15 10:16:52-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    f0cd460 View commit details
    Browse the repository at this point in the history

  6. ethclient: assert positive generic match on special case timestamp 

    Date: 2021-03-15 10:21:40-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    b3140ce View commit details
    Browse the repository at this point in the history

  7. ethclient,internal/ethapi: jsonrpc header marshaling assign totalDiff… 

    …iculty by calculation if DNE

Date: 2021-03-15 10:44:45-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    0e6d656 View commit details
    Browse the repository at this point in the history

  8. internal/ethapi: add Miner (null) to pending block JSON 

    Date: 2021-03-15 10:55:14-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    f11d477 View commit details
    Browse the repository at this point in the history

  9. ethclient,internal/ethapi: wip: totalDifficulty is fucked up; either … 

    …incrementing too big or nil

Date: 2021-03-15 11:15:25-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    6b3f223 View commit details
    Browse the repository at this point in the history

  10. ethclient: move test to 'cg' namespaced file, allows testing @ethereu… 

    …m/go-ethereum

Date: 2021-03-15 13:35:41-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    a6b943e View commit details
    Browse the repository at this point in the history

  11. ethclient: refactor test to be generic using pattern matching 

    Date: 2021-03-15 14:16:06-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    0b3cf0d View commit details
    Browse the repository at this point in the history

  12. ethclient: add Latest suffix for a more descriptive test name 

    Date: 2021-03-15 14:17:42-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    97e24db View commit details
    Browse the repository at this point in the history

  13. ethclient: extrapolate regex-based test to earliest,latest,pending 

    Date: 2021-03-15 14:48:05-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    e52bcad View commit details
    Browse the repository at this point in the history

  14. ethclient: rename test to be more conventional and descriptive 

    Date: 2021-03-15 14:50:05-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    cfcf223 View commit details
    Browse the repository at this point in the history

  15. internal/ethapi: remove dead wip-commented code 

    Date: 2021-03-15 14:50:19-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    14ec0c0 View commit details
    Browse the repository at this point in the history

  16. .github/workflows,ethclient: init Github Actions CI workflow to test … 

    …go-ethereum 1:1 cases

Date: 2021-03-15 15:16:47-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    4fd659c View commit details
    Browse the repository at this point in the history

  17. ethclient: use go subtest syntax for better descriptiveness and logging 

    Date: 2021-03-15 15:23:31-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    3b7de79 View commit details
    Browse the repository at this point in the history

  18. ethclient: additional commentary 

    Date: 2021-03-15 15:25:59-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 15, 2021
    Configuration menu
    Copy the full SHA
    904066f View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2021

  1. .github/workflows,ethclient: remove go-ethereum 1:1 comparative testing 

    This is just a little over-the-top and too
ad-hoc to be worth existence.

Date: 2021-03-16 10:33:15-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    119b604 View commit details
    Browse the repository at this point in the history

  2. ethclient: assert hash len for block hash field 

    Date: 2021-03-16 10:55:16-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 16, 2021
    Configuration menu
    Copy the full SHA
    78e602b View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2021

  1. internal/ethapi: omit the transactions field when marshaling uncle bl… 

    …ocks

Create a dedicated type for this case, switching
on it conditionally when inclTx is false;
this parameter is false only for uncle blocks.

Date: 2021-03-17 13:08:01-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    67ca5fc View commit details
    Browse the repository at this point in the history

  2. ethclient: test that the transactions field is omitted for uncles res… 

    …ponses

Date: 2021-03-17 13:30:37-05:00
Signed-off-by: meows <[email protected]>
    @meowsbits
    meowsbits committed Mar 17, 2021
    Configuration menu
    Copy the full SHA
    136e50f View commit details
    Browse the repository at this point in the history