Fix zoom centering #605
Fix zoom centering #605
Conversation
src/eterna/pose2D/Pose2D.ts
Outdated
| } else { | ||
| this._endOffsetX = this._width / 2; | ||
| this._endOffsetY = this._height / 2; | ||
| // TODO: should this be different? I need to respect if the mosue moved |
There was a problem hiding this comment.
I'm not sure about this - I feel like something should break if the user moves their mouse while zooming, but I couldn't really find an issue when testing.
There was a problem hiding this comment.
Alright, I finally found it:
chrome_sKjIFNZXIw.mp4
What happens is that if I zoom in, and while the animation is playing, move my mouse and then zoom in again, the mouse will not stay in the same world position (in this case it started outside the RNA, just to its right, but finished on the RNA)
I couldn't find a trivial and clean way to do this (which would happen by giving the screen/world conversion functions the current spacing in the middle of the animation, which isn't part of the ZOOM_SPACING array, but rather a linear value between the two).
I could calculate the value there, but that would mean that we'd calculate the progression in 3 different places, which I think is overkill.
Should I work on fixing that? Or should I document it as a known issue?
There was a problem hiding this comment.
Actually, I'm not sure if that would be enough to fix it, since the animation has to finish before we can zoom in again (or before the next zoom-in applies, IDK), so the mouse would have to move in world space either way
EDIT: No, that's probably wrong. I think the new animation starts immidiately.
There was a problem hiding this comment.
I'll open a new issue and resolve this thread before merging
src/eterna/pose2D/Pose2D.ts
Outdated
| this._endOffsetX = this._width / 2; | ||
| this._endOffsetY = this._height / 2; | ||
| // TODO: should this be different? I need to respect if the mosue moved | ||
| // also what if the user presses the button? |
There was a problem hiding this comment.
I need to add a parameter to allow it to zoom into the center of the RNA, for when the user presses the button.
This would also be useful if we'd want to allow users to choose in the settings whether they want the zoom to zoom to the mouse or to the center of the RNA.
There was a problem hiding this comment.
A problem with that is that the +/- hotkeys just simulate clicking the button, and so it isn't possible to (easily) make them behave differently.
I think that it's very out of scope for now, and it only really affects users who do use the mouse but don't use the scroll wheel
EDIT: This means that I want to make the +/- keys scroll to the center of the screen
src/eterna/pose2D/Pose2D.ts
Outdated
| this._endOffsetY = this._height / 2; | ||
| // TODO: should this be different? I need to respect if the mosue moved | ||
| // also what if the user presses the button? | ||
| // also what if the user drags in the middle of the zoom? |
There was a problem hiding this comment.
Dragging in the middle of the zoom is broken in live, and I don't see myself fixing it.
|
Looks like I haven't documented this anywhere, but I need to support touch with these changes |
|
@guyguy2001 Out of curiosity, what is the status of this PR? Should we convert to a draft? |
|
Uh I'm not sure Overall all that's left it to either reduce the scope or complete the changes I started making (which shouldn't take a lot of time), and figure out what to do wit touch zooming. (Idk whether or not it should count as a draft given all this, feel free to choose) |
|
Going to mark this as a draft since there's still more work to be done. Feel free to mark it as ready later |
No description provided.