-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added electra fields to configuration #120
base: main
Are you sure you want to change the base?
Conversation
Nimbus directly uses this repo as the source of truth for Holesky. I would very much prefer that there be a commit in The Feb 3rd date is already, for the Nimbus release pipeline, and devnet-5 shenanigans, cutting things very close, given the ACDE meeting date. I do not want to add unnecessary risk to this release process. Once that passes, sure. |
Please note that without the electra fields it's going to be difficult to startup with electra. I raised this because the existing PR won't validate against an electra configuration for teku. AFAIK this is the required configuration to be able to run with Electra enabled, or we'll be missing required configuration. |
The only other main change other than electra required things is the renaming from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Config looks good to me. Lighthouse is neutral on the issue of merging now vs later, as we don't actually use this repo (see: eth-clients/sepolia#99 (review)).
This includes the electra epoch from #119 so we rely on that merging, or can change it back to MAX_UINT64.
Basically when I was raising a PR for 119, I noticed there were a bunch of electra fields not included.
Also, potentially importantly, assuming we're wanting to switch
GOSSIP_MAX_SIZE
toMAX_PAYLOAD_SIZE
?