Skip to content

Commit

Permalink
adjustments
Browse files Browse the repository at this point in the history
  • Loading branch information
robinholzi committed May 2, 2024
1 parent 2e60b67 commit 0c70966
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 10 deletions.
7 changes: 7 additions & 0 deletions .github/actions/environment_clang.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
name: modyn-ci-tools
channels:
- conda-forge
dependencies:
- clang-18
- clang-tools
- clang-format-18
27 changes: 17 additions & 10 deletions .github/workflows/workflow.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ on:
- main
pull_request:

permissions:
contents: read
actions: read

defaults:
run:
shell: bash -l {0}
Expand Down Expand Up @@ -127,25 +131,24 @@ jobs:
timeout-minutes: 60
runs-on: ubuntu-latest
env:
CLANG_TIDY: clang-tidy-15
RUN_CLANG_TIDY: run-clang-tidy-15
# TODO: https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py
# TODO: how to bump run-clang-tidy?

CLANG_TIDY: clang-tidy-18
RUN_CLANG_TIDY: run-clang-tidy-18
steps:
- uses: actions/checkout@v4

- name: Install clang-tidy
run: |
sudo apt update
sudo apt install -y clang-tidy-15
cmake --version
- name: Install clang environment
uses: mamba-org/setup-micromamba@v1
with:
environment-file: .github/actions/environment_clang.yaml
cache-environment: true

- name: Setup pre-built grpc binaries
uses: actions/download-artifact@v4
with:
name: grpc-binaries-clang-clang++-17-Release
path: ${{github.workspace}}/install
run-id: https://github.com/eth-easl/modyn/actions/runs/8914657344 # TODO: generalize
github-token: ${{secrets.GITHUB_TOKEN}}

- name: Configure CMake
working-directory: ${{github.workspace}}
Expand Down Expand Up @@ -210,6 +213,8 @@ jobs:
with:
name: grpc-binaries-${{matrix.compiler.c}}-${{matrix.compiler.cxx}}-${{matrix.compiler.version}}-${{matrix.build-type}}
path: ${{github.workspace}}/install
run-id: https://github.com/eth-easl/modyn/actions/runs/8914657344 # TODO: generalize
github-token: ${{secrets.GITHUB_TOKEN}}

- name: Create Build Environment
run: cmake -E make_directory ${{github.workspace}}//build
Expand Down Expand Up @@ -289,6 +294,8 @@ jobs:
with:
name: grpc-binaries-clang-clang++-17-Release
path: ${{github.workspace}}/install
run-id: https://github.com/eth-easl/modyn/actions/runs/8914657344 # TODO: generalize
github-token: ${{secrets.GITHUB_TOKEN}}

- name: Create Build Environment
run: |
Expand Down

0 comments on commit 0c70966

Please sign in to comment.