Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce common ModynModel Format #48

Open
MaxiBoether opened this issue Dec 23, 2022 · 4 comments
Open

Introduce common ModynModel Format #48

MaxiBoether opened this issue Dec 23, 2022 · 4 comments
Labels
enhancement New feature or request Trainer Server

Comments

@MaxiBoether
Copy link
Contributor

MaxiBoether commented Dec 23, 2022

PR #45 initializes a model directory with a dummy ResNet18 class. We need to think about how exactly our models will be implemented, i.e., is it just the class itself, or some meta-wrapper around the concrete implementation (for example, to be able to abstract PyTorch/Tensorflow/...). Then of course, we need to implement some models there.

Maybe it also makes sense to move the models directory into the frontend directory. I will think about that.

This was referenced Dec 23, 2022
@vGsteiger vGsteiger added the enhancement New feature or request label Dec 23, 2022
@MaxiBoether MaxiBoether changed the title Decide how to implement models + implement simple model Model implementation format Jan 10, 2023
@MaxiBoether
Copy link
Contributor Author

PR #56 introduces a ResNet18 example for PyTorch. This solves previous parts of this issue (implementing a simple model). I think the scope of this issue should be a little different: We should define a general ModynModel class and let other models inherit from this, and build it in a way that (at least for future PRs) support both PyTorch and Tensorflow implementations. PR #56 assumes PyTorch for now, but we will want to generalize a bit here

@vGsteiger
Copy link
Collaborator

Is this still an open issue or has it been rediscussed in other issues such as #127 and #111

@MaxiBoether
Copy link
Contributor Author

MaxiBoether commented Feb 2, 2023

It's still somewhat part of a larger issue. Right now we just assume torch. However, in a perfect world, Modyn would support at least Torch/Tensorflow/would be independent as good as possible of torch. For this we probably still need some form of structure in the future that allows us to obtain the correct implementation for each framework. That is what this issue is about

@MaxiBoether MaxiBoether changed the title Model implementation format Introduce common ModynModel Format Aug 14, 2023
@MaxiBoether
Copy link
Contributor Author

Pr #294 introduces some functionality models should implement to support Coreset functionality. It was the goal to introduce a ´ModynModel` class in that PR, but did not work out as outlined in the comment here by @francescodeaglio. We should find a way around this and refactor the models into a common parent class.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Trainer Server
Projects
None yet
Development

No branches or pull requests

2 participants