-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce common ModynModel Format #48
Comments
PR #56 introduces a ResNet18 example for PyTorch. This solves previous parts of this issue (implementing a simple model). I think the scope of this issue should be a little different: We should define a general ModynModel class and let other models inherit from this, and build it in a way that (at least for future PRs) support both PyTorch and Tensorflow implementations. PR #56 assumes PyTorch for now, but we will want to generalize a bit here |
It's still somewhat part of a larger issue. Right now we just assume torch. However, in a perfect world, Modyn would support at least Torch/Tensorflow/would be independent as good as possible of torch. For this we probably still need some form of structure in the future that allows us to obtain the correct implementation for each framework. That is what this issue is about |
Pr #294 introduces some functionality models should implement to support Coreset functionality. It was the goal to introduce a ´ModynModel` class in that PR, but did not work out as outlined in the comment here by @francescodeaglio. We should find a way around this and refactor the models into a common parent class. ![]() |
PR #45 initializes a model directory with a dummy ResNet18 class. We need to think about how exactly our models will be implemented, i.e., is it just the class itself, or some meta-wrapper around the concrete implementation (for example, to be able to abstract PyTorch/Tensorflow/...). Then of course, we need to implement some models there.
Maybe it also makes sense to move the
models
directory into thefrontend
directory. I will think about that.The text was updated successfully, but these errors were encountered: