-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce CoresetMethodsSupport #294
Conversation
✅ Result of Pytest Coverage---------- coverage: platform linux, python 3.11.5-final-0 -----------
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I think the biggest change is that we should have one ModynModel class which handles everything for Modyn models, not just recording embeddings. For example, the amp setting etc. This should be the first change and then I just had a few smaller comments. thanks again :)
modyn/selector/internal/selector_strategies/abstract_selection_strategy.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Almost done. I just had some confusion on the get_label thingy, after this is resolved we can merge this. Thank you!
modyn/selector/internal/selector_strategies/abstract_selection_strategy.py
Show resolved
Hide resolved
modyn/tests/selector/internal/selector_strategies/test_abstract_selection_strategy.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, LGTM! Feel free to merge.
Many DeepCore methods require obtaining the last layer and using an embedding recorder. This PR introduces the CoresetMethodsSupport class that must be inherited in order to use these methods.