-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Local Storage Backend #364
Conversation
✅ Result of Pytest Coverage---------- coverage: platform linux, python 3.12.3-final-0 -----------
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Ties! I am pre-approving this but have two comments:
-
the structure of the CPP wrapper (it should go into the storage component instead of common I think, since it's not a common utility, unlike the TSS).
-
a couple of C++ tests similar to the TSS would be amazing
Thank you so much. After adjusting this feel free to merge.
modyn/selector/internal/storage_backend/local/local_storage_backend.py
Outdated
Show resolved
Hide resolved
modyn/selector/internal/storage_backend/local/local_storage_backend.py
Outdated
Show resolved
Hide resolved
modyn/tests/selector/internal/storage_backend/local/test_local_storage_backend.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Only the Dockerfile thing I think we need to change, everything else LGTM! Thanks!
#262 --------- Co-authored-by: Maximilian Böther <[email protected]> Co-authored-by: Maximilian Böther <[email protected]>
#262