chore: Support pre-build grpc artefacts for CI jobs #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Result of Pytest Coverage---------- coverage: platform linux, python 3.12.3-final-0 -----------
|
|
|
MaxiBoether
reviewed
May 2, 2024
| absl::random_random | ||
| ) | ||
|
|
||
| target_link_libraries(modyn-storage-proto PUBLIC protobuf::libprotobuf grpc_unsecure gpr libaddress_sorting.a libupb.a libcares.a libz.a utf8_range ${protobuf_ABSL_USED_TARGETS}) |
There was a problem hiding this comment.
Just a note: At the time, this all was somewhat necessary to make it work with local gRPC because otherwise we were running into tons of linking issues. It could be that something changed about abseil/grpc, but there was a reason that we did all of this shenanigans :D
There was a problem hiding this comment.
I ran the full build pipeline from scratch using both local and pre-built grpc. I didn't encounter any linking errors so I assumed this wouldn't be needed (also in documentations online this isn't needed)
|
If you can actually cache the gRPC binaries, that would be amazing. Thanks so much for the effort here. |
robinholzi
changed the title
robinholzi
force-pushed
the
robinholzi/chore/grpc-build-workflow
branch
from
2f77f1d to
c30002d
Compare
robinholzi
force-pushed
the
robinholzi/chore/grpc-build-workflow
branch
from
c30002d to
50aa179
Compare
robinholzi
force-pushed
the
robinholzi/chore/grpc-build-workflow
branch
from
a22109d to
463c9ba
Compare
robinholzi
added a commit
that referenced
this pull request
May 14, 2024
# Motivation Integration tests configs are currently hard coded. It would be could to be able to centrally configure the config dir for the integration config files to be able to test new versions locally. Being able to place them outside of Git VCS would make debugging easier. C++/Cmake config enabling linking with precompiled grpc is taken from #411
|
Closing for now as I don't intend to spend more time on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I want to speed up the CI. I want to build a workflow that periodically compiles all grpc binaries via a CI matrix. The build artifacts can then be used for linking grpc in the other CI workflows.
However, to build up this CI workflow I will need a couple of iterations.
Therefore I want to merge this dummy workflow so I can have the workflow triggered onpull_request.** Update: Seems as if repo settings allow CI workflow runs on freshly introduced workflows.
Open questions
Bugfixes