Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add thesis plotting tools #624

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

robinholzi
Copy link
Collaborator

@robinholzi robinholzi commented Sep 7, 2024

WIP

Copy link

github-actions bot commented Sep 7, 2024

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 85.58%. Comparing base (c33c384) to head (85e88a1).

Files with missing lines Patch % Lines
...pervisor/internal/triggers/drift/detector/alibi.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #624      +/-   ##
==========================================
- Coverage   85.61%   85.58%   -0.04%     
==========================================
  Files         258      258              
  Lines       11334    11349      +15     
==========================================
+ Hits         9704     9713       +9     
- Misses       1630     1636       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +140 to +153
" evaluation_center = (eval_request.interval_start + eval_request.interval_end) / 2\n",
"\n",
" eval_request.currently_active_model = (\n",
" evaluation_center - offset\n",
" <= model_row.iloc[0][\"train_end\"].to_pydatetime().timestamp()\n",
" <= evaluation_center\n",
" )\n",
"\n",
" # training_center = (\n",
" # model_row.iloc[0][\"train_start\"].to_pydatetime().timestamp()\n",
" # + model_row.iloc[0][\"train_end\"].to_pydatetime().timestamp()\n",
" # ) / 2\n",
" # eval_request.currently_active_model = eval_request.currently_trained_model\n",
" # eval_request.currently_trained_model = (\n",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you remember what the changes in this file are for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants