Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Fix type hint #627

Merged
merged 1 commit into from
Sep 10, 2024
Merged

hotfix: Fix type hint #627

merged 1 commit into from
Sep 10, 2024

Conversation

MaxiBoether
Copy link
Contributor

Not sure why my local pre commit hooks/even just running mypy doesn't catch this, probably some inconsistency between CI config and local config

@XianzheMa XianzheMa self-requested a review September 10, 2024 09:22
@MaxiBoether
Copy link
Contributor Author

thanks xianzhe :)

@MaxiBoether MaxiBoether merged commit 22aaaed into main Sep 10, 2024
16 checks passed
@MaxiBoether MaxiBoether deleted the fix/MaxiBoether/mypyplot branch September 10, 2024 09:23
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (46137c3) to head (65b2b39).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #627   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files         258      258           
  Lines       11311    11311           
=======================================
  Hits         9683     9683           
  Misses       1628     1628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants