Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not use model_id in Pydantic #628

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

MaxiBoether
Copy link
Contributor

For the dict, we probably do not need to change this, but let's just avoid any potential conflict.

@MaxiBoether MaxiBoether merged commit dfa752e into main Sep 10, 2024
16 checks passed
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (46137c3) to head (89bbf92).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #628   +/-   ##
=======================================
  Coverage   85.60%   85.60%           
=======================================
  Files         258      258           
  Lines       11311    11311           
=======================================
  Hits         9683     9683           
  Misses       1628     1628           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants