Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update experiment configs and bugfixes #631

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

robinholzi
Copy link
Collaborator

@robinholzi robinholzi commented Sep 10, 2024

Motivation

Final changes from thesis.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 85.59%. Comparing base (c33c384) to head (82166ba).

Files with missing lines Patch % Lines
.../internal/pipeline_executor/evaluation_executor.py 30.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #631      +/-   ##
==========================================
- Coverage   85.61%   85.59%   -0.03%     
==========================================
  Files         258      258              
  Lines       11334    11338       +4     
==========================================
+ Hits         9704     9705       +1     
- Misses       1630     1633       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Line Coverage: -% ( % to main)
Branch Coverage: -% ( % to main)

@@ -103,10 +103,14 @@ def inform_new_model(
) -> None:
"""Update the cost tracker with the new model metadata."""
self._unincorporated_samples = 0

# reset regret
self.latency_tracker.inform_trigger()
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix

@@ -154,4 +157,36 @@ def _alibi_detect_metric_factory(config: AlibiDetectDriftMetric, embeddings_ref:
**kwargs,
)

if isinstance(config, AlibiDetectLSDDDriftMetric):
return LSDDDrift(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New

@@ -24,9 +24,6 @@ def _batch_evaluated_callback(self, y_true: torch.Tensor, y_pred: torch.Tensor,
self.total_correct += labeled_correctly
self.samples_seen += batch_size

self.total_correct += labeled_correctly
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bugfix

AlibiDetectDriftMetric = Annotated[
AlibiDetectMmdDriftMetric | AlibiDetectKSDriftMetric | AlibiDetectCVMDriftMetric,
AlibiDetectMmdDriftMetric
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added more drift detectors.

@@ -1,17 +1,16 @@
import os
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

various experiments for thesis

@@ -2,12 +2,15 @@

import pandas as pd
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various thesis experiments for huffpost.

@@ -2,12 +2,16 @@

import pandas as pd
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various thesis experiments for arxiv.

transformed["category"] = pd.Categorical(transformed["category"]).codes
if not keep_true_category:
# to int-categorical
transformed["category"] = pd.Categorical(transformed["category"]).codes
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For exploring dataset with original labels.

@robinholzi robinholzi changed the title chore: Update experiment configs chore: Update experiment configs and bugfixes Dec 28, 2024
@robinholzi robinholzi self-assigned this Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant