-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated storage and training files to enable text generation tasks. A… #640
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,7 +30,7 @@ dependencies: | |
- psycopg2 | ||
- sqlalchemy>=2.0 | ||
- pyaml | ||
- pydantic | ||
- pydantic==2.9.2 | ||
- numpy==1.26.* | ||
- pandas | ||
- bitstring | ||
|
@@ -43,11 +43,10 @@ dependencies: | |
- nltk | ||
- pytorch::pytorch=2.2.1 | ||
- pytorch::torchvision | ||
- pytorch::cpuonly # comment out if commenting in lines below for CUDA | ||
# - pytorch::pytorch-cuda=12.1 | ||
# - nvidia::cuda-libraries-dev=12.1.* | ||
# - nvidia::cuda-nvcc=12.1.* | ||
# - nvidia::cuda-nvtx=12.1.* | ||
# - nvidia::cuda-cupti=12.1.* | ||
# - nvidia::cuda-cudart-dev=12.1.* | ||
# - nvidia::cuda-profiler-api=12.1.* | ||
- pytorch::pytorch-cuda=12.1 | ||
- nvidia::cuda-libraries-dev=12.1.* | ||
- nvidia::cuda-nvcc=12.1.* | ||
- nvidia::cuda-nvtx=12.1.* | ||
- nvidia::cuda-cupti=12.1.* | ||
- nvidia::cuda-cudart-dev=12.1.* | ||
- nvidia::cuda-profiler-api==12.1.* | ||
Comment on lines
-48
to
+52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. should be commented out. no changes here should be necessary |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -278,7 +278,7 @@ selector: | |
local_storage_directory: "/tmp/local_storage" | ||
local_storage_max_samples_in_file: 1000000 | ||
cleanup_storage_directories_after_shutdown: true | ||
ignore_existing_trigger_samples: false | ||
ignore_existing_trigger_samples: true | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. let's not merge this |
||
|
||
trainer_server: | ||
hostname: "trainer_server" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -255,7 +255,7 @@ class SelectorConfig(HostnamePortMixin): | |
), | ||
) | ||
ignore_existing_trigger_samples: bool = Field( | ||
False, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. also shouldnt merge that |
||
True, | ||
description=( | ||
"Whether to ignore existing trigger samples when starting the selector. If set to false, the trigger " | ||
"sample directory has to be empty upon startup. May lead to unexpected behaviour if set to true and the " | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be solved with the latest commit on main