Skip to content

Commit

Permalink
Merge pull request #242 from omahs/patch-1
Browse files Browse the repository at this point in the history
fix: typos
  • Loading branch information
jakim929 authored Oct 31, 2024
2 parents eef8f77 + cea2c58 commit 661a6f3
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion contracts/src/SuperchainETHWrapper.sol
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {ISuperchainWETH} from "@contracts-bedrock/L2/interfaces/ISuperchainWETH.
/**
* @notice Thrown when the relay of SuperchainWETH has not succeeded.
* @dev This error is triggered if the SuperchainWETH relay through the L2ToL2CrossDomainMessenger
* has not completed successfully successful.
* has not completed successfully.
*/
error RelaySuperchainWETHNotSuccessful();

Expand Down
16 changes: 8 additions & 8 deletions contracts/src/tictactoe/TicTacToe.sol
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,13 @@ error IdChainMismatch();
/// @notice Thrown when a player tries to play themselves;
error SenderIsOpponent();

/// @notice Thrown when the exepcted event is not NewGame
/// @notice Thrown when the expected event is not NewGame
error DataNotNewGame();

/// @notice Thrown when the exepcted event is not AcceptedGame
/// @notice Thrown when the expected event is not AcceptedGame
error DataNotAcceptedGame();

/// @notice Thrown when the exepcted event is not MovePlayed
/// @notice Thrown when the expected event is not MovePlayed
error DataNotMovePlayed();

/// @notice Thrown when the caller is not allowed to act
Expand All @@ -40,13 +40,13 @@ error MoveInvalid();
/// @notice Thrown when the consumed event is not forward progressing the game.
error MoveNotForwardProgressing();

/// @notice Thrown when the player make a move that's already been played
/// @notice Thrown when the player makes a move that's already been played
error MoveTaken();

/// @title TicTacToe
/// @notice TicTacToe is a Superchain interoprable implementation of TicTacToe where players
/// can play each other from any two chains in each others interopable dependency sets
/// without needing to pass messages between themselves. Since a chain is be default in
/// @notice TicTacToe is a Superchain interoperable implementation of TicTacToe where players
/// can play each other from any two chains in each others interoperable dependency sets
/// without needing to pass messages between themselves. Since a chain is by default in
/// its own dependency set, players on the same chain can also play each other :)
contract TicTacToe {
uint256 public nextGameId;
Expand All @@ -65,7 +65,7 @@ contract TicTacToe {
ICrossL2Inbox.Identifier lastOpponentId;
}

/// @notice A game is identifed from the (chainId, gameId) tuple from the chain it was initiated on
/// @notice A game is identified from the (chainId, gameId) tuple from the chain it was initiated on
/// Since players on the same chain can play each other, we need to subspace by address as well.
mapping(uint256 => mapping(uint256 => mapping(address => Game))) games;

Expand Down
2 changes: 1 addition & 1 deletion docs/src/guides/interop/cross-chain-contract-via-l2cdm.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ function hitBallTo(uint256 _toChainId) public {
...
}
```
- The `ball` contract variable is populated on the chain, indicating it's presence
- The `ball` contract variable is populated on the chain, indicating its presence
- The destination must be a different chain

#### 2. Define The Receiving Handler
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ topics: [
...
```

### 5. Retrive the block timestamp the log was emitted in
### 5. Retrieve the block timestamp the log was emitted in

Since the message identifier requires the block timestamp, fetch the block info to get the timestamp.

Expand Down

0 comments on commit 661a6f3

Please sign in to comment.