Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Improvements #104

Open
Tracked by #308
tremarkley opened this issue Aug 14, 2024 · 13 comments · May be fixed by #295
Open
Tracked by #308

Config Improvements #104

tremarkley opened this issue Aug 14, 2024 · 13 comments · May be fixed by #295
Assignees
Labels

Comments

@tremarkley
Copy link
Contributor

  • toml file that gets parsed and the values are passed in as cli args
@Gerson2102
Copy link

Gerson2102 commented Oct 30, 2024

Hey! Can I work on it? @tremarkley @jakim929

@Ethanol48
Copy link
Contributor

Ethanol48 commented Oct 31, 2024

@tremarkley @jakim929 Could I work on this feature?

@jakim929
Copy link
Contributor

jakim929 commented Nov 1, 2024

@Gerson2102 feel free to take a stab!

Some starters -

  • I think the starting point is a supersim.toml file that can be passed as a flag to supersim
  • Can maybe use https://github.com/BurntSushi/toml
  • It should try to have similar structure to the existing config object, by adding struct tags Name toml:name

@Ethanol48 - since this one is assigned, would appreciate your contribution on any other issues!

@Ethanol48
Copy link
Contributor

@Gerson2102 feel free to take a stab!

Some starters -

  • I think the starting point is a supersim.toml file that can be passed as a flag to supersim

  • Can maybe use https://github.com/BurntSushi/toml

  • It should try to have similar structure to the existing config object, by adding struct tags Name toml:name

@Ethanol48 - since this one is assigned, would appreciate your contribution on any other issues!

Could I work on this issue?
#150

@Gerson2102
Copy link

Hi @jakim929. Do you guys have a Telegram group or something like that to ask questions while I'm working with this issue?

@jakim929
Copy link
Contributor

jakim929 commented Nov 1, 2024

@Gerson2102 feel free to join this one https://t.me/+IfzdrLjf2_pkNmUx

@Gerson2102
Copy link

I'm having problems on setting up the project :(

I'm using WSL2

@s29papi
Copy link
Contributor

s29papi commented Nov 15, 2024

@Gerson2102 made any progress on this ? Can i try at it ?

@s29papi
Copy link
Contributor

s29papi commented Nov 25, 2024

@jakim929 can I try at this ?

@s29papi
Copy link
Contributor

s29papi commented Dec 3, 2024

@tremarkley I want to take on this. Can it be re-assigned

@tremarkley tremarkley assigned s29papi and unassigned Gerson2102 Dec 4, 2024
@tremarkley
Copy link
Contributor Author

@s29papi re-assigned to you

@s29papi s29papi linked a pull request Dec 5, 2024 that will close this issue
@fainashalts
Copy link
Collaborator

@s29papi are you still planning to work on this? or should we reassign? thanks!

@s29papi
Copy link
Contributor

s29papi commented Dec 18, 2024

@fainashalts i have completed this and my pr mentions this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants