Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/added toml supersim config closes #104 #295

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

s29papi
Copy link
Contributor

@s29papi s29papi commented Dec 5, 2024

Description

This pull request implements significant improvements to the configuration handling of the application. The changes include the addition of a TOML configuration file that is parsed, allowing values to be passed in as command-line arguments. The configuration values from the TOML file take precedence over those provided via CLI flags, ensuring a more flexible and user-friendly configuration experience.

Tests

Comprehensive tests have been added to verify the correct parsing of the TOML file and the proper application of configuration values. The tests ensure that:

  • The application correctly reads and applies values from the TOML file.
  • CLI arguments are overridden by values from the TOML file when both are provided.
  • All edge cases, such as missing or default values, are handled appropriately.

Additional context

These improvements address the need for a more robust configuration management system, allowing users to define their settings in a structured format while still providing the flexibility of command-line overrides. This change enhances usability and aligns with best practices for configuration management.

Metadata

@s29papi s29papi requested a review from a team as a code owner December 5, 2024 09:39
@s29papi s29papi changed the title Feat/added toml supersim config Feat/added toml supersim config closes #104 Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Config Improvements
1 participant