Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker image tests #206

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

janjakubnanista
Copy link
Contributor

@janjakubnanista janjakubnanista commented Oct 17, 2024

Description

  • Adding smoke tests for linux/amd64 and linux/arm64 images to the CI pipeline. These tests check that the Dockerfile can be built as well as that the supersim executable runs fine when the image is run

Tests

  • Yesssss

Additional context

Metadata

@janjakubnanista janjakubnanista requested a review from a team as a code owner October 17, 2024 20:25
@janjakubnanista janjakubnanista marked this pull request as draft October 17, 2024 23:11
@janjakubnanista janjakubnanista marked this pull request as ready for review October 17, 2024 23:18
@janjakubnanista janjakubnanista force-pushed the docker-test branch 4 times, most recently from 0c281ac to 16ce4f3 Compare October 22, 2024 17:27
@janjakubnanista
Copy link
Contributor Author

@nitaliano I have just rebased this on top of the test fixes, should be good now

@janjakubnanista janjakubnanista force-pushed the docker-test branch 3 times, most recently from 2b42cac to 4f0c90c Compare October 29, 2024 17:43
@nitaliano
Copy link
Contributor

just getting back to this @janjakubnanista i'm wondering if something is up with the linux/arm64 tests these are taking a very long time to finish compared to the amd64 one

@janjakubnanista
Copy link
Contributor Author

@nitaliano ah yeah the emulation is quite computationally intensive (github machines are amd64 and need to use QEMU when running docker for other architectures). They can be removed since the only other solution is to use a different runner which is a paid thing.

@nitaliano
Copy link
Contributor

yea i think this is good to merge in once we get rid of arm64 once this gets merged in would like to make the docker test as a required CI check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants