Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds basic tic tac toe game #27

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Adds basic tic tac toe game #27

merged 2 commits into from
Jun 27, 2024

Conversation

nitaliano
Copy link
Contributor

@nitaliano nitaliano commented Jun 26, 2024

Description

  • Adds basic TicTacToe contract along with unit tests. This is a test contract we're going to continue to evolve to demonstrate how interop works.
  • Removes the counter contracts

How to play

  • Player1 calls createGame this returns a game id
  • Player2 calls joinGame with the game id
  • Player1 has the first turn, then they rotate until a draw or game is won, the players call makeMove with game id and spot on the board.

Tracker: #3

@nitaliano nitaliano marked this pull request as ready for review June 26, 2024 20:26
@nitaliano nitaliano requested a review from a team as a code owner June 26, 2024 20:26
Copy link
Contributor

@tremarkley tremarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be overkill, but should we have verification that makes sure the address making a move or creating the game is the actual owner of that address? with the way the game is set up right now, anyone can make a move or create a game on behalf of any address.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea i did it this way intentionally, because I'm going to try and get the FE to also work with smart accounts and just wanted it to be easier to setup at first.

@nitaliano nitaliano merged commit f40e1e8 into main Jun 27, 2024
1 check passed
@nitaliano nitaliano deleted the nick/tic-tac-toe branch June 27, 2024 13:29
@nitaliano nitaliano mentioned this pull request Jul 9, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants