Adds odyssey support #302
Merged
Adds odyssey support #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitaliano
force-pushed
the
odyssey-support
branch
from
b829b17 to
eae3802
Compare
Deploying supersim with
|
| Latest commit: |
7cb43f5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23d1322e.supersim.pages.dev |
| Branch Preview URL: | https://odyssey-support.supersim.pages.dev |
tremarkley
approved these changes
Dec 16, 2024
| // Spin up L1 anvil instance | ||
| l1Anvil := anvil.New(log, closeApp, &networkConfig.L1Config) | ||
| l1Cfg := networkConfig.L1Config | ||
| if cliConfig != nil { |
There was a problem hiding this comment.
would you prefer having this here over applying it to the networkConfig in supersim.go. Similar to how we apply the other cli configs? https://github.com/ethereum-optimism/supersim/blob/main/supersim.go#L64
There was a problem hiding this comment.
Yea I initially put it in the network config, the problem is the network config doesn't get passed down to where we setup anvil only the chain config gets passed all the way down. The interop portion you linked too is being utilized after everything is up and running. I considered adding the field to the network configs still but it would result in more code just copying the field over to the chain config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new cli flag
--odyssey.enabled. It adds support to start both the L1 & L2 anvil instances with odyssey features enabled allowing developers to start testing out more experimental features multichain