Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add startup logging #31

Merged
merged 2 commits into from
Jul 9, 2024
Merged

feat: add startup logging #31

merged 2 commits into from
Jul 9, 2024

Conversation

jakim929
Copy link
Contributor

@jakim929 jakim929 commented Jun 28, 2024 •
edited
Loading

waits until the anvil nodes are ready to accept requests, then prints chain id and RPC configs

Supersim Config:
L1:
  Chain ID: 1    RPC: http://127.0.0.1:8545
L2:
  Chain ID: 10    RPC: http://127.0.0.1:9545
  Chain ID: 30    RPC: http://127.0.0.1:9555

@jakim929 jakim929 changed the title feat: startup logging feat: add ready check for anvil Jun 28, 2024
@jakim929
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @jakim929 and the rest of your teammates on Graphite Graphite

@jakim929 jakim929 force-pushed the 06-27-feat_startup_logging branch 4 times, most recently from 0f49ef6 to 6b703c2 Compare June 28, 2024 21:28
@jakim929 jakim929 changed the title feat: add ready check for anvil feat: add startup logging Jun 28, 2024
@jakim929 jakim929 marked this pull request as ready for review June 28, 2024 21:30
@jakim929 jakim929 requested a review from a team as a code owner June 28, 2024 21:30
tremarkley
tremarkley approved these changes Jul 8, 2024
View reviewed changes
anvil/anvil.go Show resolved Hide resolved
hamdiallam
hamdiallam reviewed Jul 8, 2024
View reviewed changes
Copy link
Contributor

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! Left a few comments

utils/rpc.go Outdated Show resolved Hide resolved
utils/rpc.go Outdated Show resolved Hide resolved
supersim.go Outdated Show resolved Hide resolved
@jakim929 jakim929 force-pushed the 06-27-feat_startup_logging branch from 4c2a040 to 13db488 Compare July 9, 2024 14:59
@jakim929 jakim929 requested a review from hamdiallam July 9, 2024 15:00
@jakim929 jakim929 force-pushed the 06-27-feat_startup_logging branch from 13db488 to a167a84 Compare July 9, 2024 15:02
@jakim929 jakim929 merged commit ca8aac7 into main Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tremarkley tremarkley tremarkley approved these changes

@hamdiallam hamdiallam Awaiting requested review from hamdiallam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakim929 @hamdiallam @tremarkley