supersim testsuite creator #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremarkley
approved these changes
Jul 9, 2024
Comment on lines
+26
to
+28
| Cfg *Config | ||
| Supersim *Supersim |
There was a problem hiding this comment.
is there a reason that these fields should be public?
There was a problem hiding this comment.
For now they could technically be private. I made them public in the even this test suite is used in a diff package
tremarkley
approved these changes
Jul 9, 2024
hamdiallam
force-pushed
the
supersim.testsuite
branch
from
f152658 to
803a3de
Compare
fainashalts
approved these changes
Jul 9, 2024
hamdiallam
force-pushed
the
supersim.testsuite
branch
from
d12c18b to
a4e7947
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2
a test suite wrapper over a running instance of supersim. This makes it DRY between tests.
This wrapper will evolve as tests are added
Also introduces a dependency on stretchr/testify to write cleaner tests