anvil logs to a tmp file #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitaliano
reviewed
Jul 10, 2024
| for _, l2OpSim := range s.l2OpSims { | ||
| fmt.Fprintf(&b, " Chain ID: %d RPC: %s\n", l2OpSim.ChainId(), l2OpSim.Endpoint()) | ||
| for id, l2OpSim := range s.l2OpSims { | ||
| fmt.Fprintf(&b, " Chain ID: %d RPC: %s LogPath: %s\n", l2OpSim.ChainId(), l2OpSim.Endpoint(), s.l2Anvils[id].LogPath()) |
There was a problem hiding this comment.
i doubt this will happen the way everything is setup but i'm wondering if we should add a nil check for this specifically s.l2Anvils[id].LogPath()
There was a problem hiding this comment.
hmm given the setup there's no good way to gracefully recover from a programming mistake here so better to simply panic
we can add a unit test though that asserts the key is present in both maps when setup. That should cover this case
nitaliano
reviewed
Jul 10, 2024
| @@ -90,7 +92,12 @@ func (a *Anvil) Start(ctx context.Context) error { | |||
| anvilPortCh := make(chan uint64) | |||
|
|
|||
| // Handle stdout/stderr | |||
| // - TODO: Figure out best way to dump into logger. Some hex isn't showing appropriately | |||
| logFile, err := os.CreateTemp("", fmt.Sprintf("anvil-chain-%d-", a.cfg.ChainId)) | |||
There was a problem hiding this comment.
ah this was a mistake, will remove
There was a problem hiding this comment.
ah wait no actually the extra - is there becase CreateTemp appends a random string of characters at the end for name collision
nitaliano
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for now we rely on inspecting the anvil logs to grab the port when bound to
0.Rather than use the
--silentflag, dump anvil log to temporary files such that they are inspectable for the user