Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: interop invariant checks #58

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

tremarkley
Copy link
Contributor

@tremarkley tremarkley commented Jul 22, 2024

Closes: #19
Closes: #18

Adds interop invariant checks to the opsimulator, and will reject transactions that do not meet the interop invariants. The interop invariant checks are in line with the interop spec: https://specs.optimism.io/interop/overview.html

@tremarkley
Copy link
Contributor Author

tremarkley commented Jul 22, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @tremarkley and the rest of your teammates on Graphite Graphite

@tremarkley tremarkley force-pushed the harry/interop_invariant_checks branch 11 times, most recently from 71aeb12 to bbe0bf1 Compare July 30, 2024 00:59
@tremarkley tremarkley force-pushed the harry/interop_invariant_checks branch 13 times, most recently from d4f48f4 to 85e420b Compare August 1, 2024 23:32
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
crossl2inbox/crossl2inbox.go Outdated Show resolved Hide resolved
@tremarkley tremarkley force-pushed the harry/interop_invariant_checks branch from 85e420b to 88441eb Compare August 1, 2024 23:53
@tremarkley tremarkley force-pushed the harry/interop_invariant_checks branch from 8106add to 1c01ca2 Compare August 2, 2024 22:43
@tremarkley tremarkley force-pushed the harry/interop_invariant_checks branch from 1c01ca2 to d518988 Compare August 2, 2024 22:54
@tremarkley tremarkley marked this pull request as ready for review August 2, 2024 22:58
@tremarkley tremarkley requested a review from a team as a code owner August 2, 2024 22:58
@tremarkley tremarkley force-pushed the harry/interop_invariant_checks branch 7 times, most recently from 8156782 to 975a0be Compare August 5, 2024 20:18
@tremarkley tremarkley requested a review from tynes August 5, 2024 20:23
Copy link
Contributor

@hamdiallam hamdiallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left some feedback

Some of the interop checks can be pulled into utility functions but we can iterate on that instead of trying to get it right first

crossl2inbox/crossl2inbox.go Outdated Show resolved Hide resolved
crossl2inbox/crossl2inbox.go Outdated Show resolved Hide resolved
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
opsimulator/opsimulator.go Outdated Show resolved Hide resolved
@tremarkley tremarkley force-pushed the harry/interop_invariant_checks branch 11 times, most recently from 544b9cf to 9913d6c Compare August 6, 2024 22:02
@tremarkley tremarkley force-pushed the harry/interop_invariant_checks branch from 9913d6c to eaee40b Compare August 6, 2024 22:07
@tremarkley tremarkley merged commit 98123b8 into main Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants