Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-6909: ERC-6909 nits #678

Merged
merged 7 commits into from
Oct 20, 2024

Conversation

jtriley-eth
Copy link
Contributor

  • moved eip to erc where relevant
  • added explicit requirement for ERC-165 implementation
  • change metadata method descriptions (name/symbol) to say "_ for a token id" rather than "_ of the contract"
  • added backticks where relevant

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 20, 2024

✅ All reviewers have approved.

@eip-review-bot eip-review-bot changed the title ERC-6909 nits Update ERC-6909: ERC-6909 nits Oct 20, 2024
@eip-review-bot eip-review-bot enabled auto-merge (squash) October 20, 2024 01:13
eip-review-bot
eip-review-bot previously approved these changes Oct 20, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

auto-merge was automatically disabled October 20, 2024 01:18

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) October 20, 2024 01:19
eip-review-bot
eip-review-bot previously approved these changes Oct 20, 2024
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

Copy link

The commit 8494a2a (as a parent of a1b28ad) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Oct 20, 2024
auto-merge was automatically disabled October 20, 2024 01:30

Head branch was pushed to by a user without write access

@eip-review-bot eip-review-bot enabled auto-merge (squash) October 20, 2024 01:31
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit ffb8f31 into ethereum:master Oct 20, 2024
9 of 17 checks passed
@github-actions github-actions bot removed the w-ci label Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants