Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ERC: Conditional send transaction RPC #682

Conversation

forshtat
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Oct 22, 2024

✅ All reviewers have approved.

@forshtat forshtat changed the title Aa 456 send transaction conditional eip7702 Add ERC: Send Transaction Conditional RPC API Oct 22, 2024
@github-actions github-actions bot added the w-ci label Oct 22, 2024
@@ -0,0 +1,158 @@
---
eip: send-tx-cond
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eip: send-tx-cond
eip: 7796

Assigning next sequential EIP/ERC/RIP number.

Please also update the filename.

title: Conditional send transaction RPC
description: JSON-RPC API for block builders allowing users to express preconditions for transaction inclusion
author: Dror Tirosh (@drortirosh), Yoav Weiss (@yoavw), Alex Forshtat (@forshtat), Shahaf Nacson (@shahafn)
discussions-to:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create a discussions topic in Eth Magicians: https://ethereum-magicians.org/c/ercs/57

@eip-review-bot eip-review-bot changed the title Add ERC: Send Transaction Conditional RPC API Add ERC: Conditional send transaction RPC Oct 27, 2024
@github-actions github-actions bot removed the w-ci label Oct 27, 2024
Copy link

The commit 92a1369 (as a parent of 5a2d0a1) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot added the w-ci label Oct 27, 2024
@forshtat forshtat marked this pull request as ready for review October 29, 2024 14:14
ERCS/erc-7796.md Outdated Show resolved Hide resolved
ERCS/erc-7796.md Outdated Show resolved Hide resolved

* Method: `eth_sendRawTransactionConditional`

* Parameters:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to see JSON Schema for this, especially if the goal is to add this to https://ethereum.github.io/execution-apis/api-documentation/ eventually.

ERCS/erc-7796.md Outdated Show resolved Hide resolved
forshtat and others added 3 commits October 29, 2024 15:19
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
@github-actions github-actions bot added the t-erc label Oct 29, 2024
@eip-review-bot eip-review-bot enabled auto-merge (squash) October 29, 2024 14:32
Copy link
Collaborator

@eip-review-bot eip-review-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Reviewers Have Approved; Performing Automatic Merge...

@eip-review-bot eip-review-bot merged commit 7d97810 into ethereum:master Oct 29, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants