Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ERC: Minimal Batch Executor Interface #726
base: master
Are you sure you want to change the base?
Add ERC: Minimal Batch Executor Interface #726
Changes from 25 commits
3658226
5f7f65b
e9ccf92
1c4d117
5eef39b
4f72d55
35943d6
dd14d7d
da0b5cc
54e2dbe
1aff3f6
5423d22
8b9f9d2
43c4269
05bc842
d82eac8
580b8a7
2650252
f9fa123
c682383
c94285a
aede948
ad51da0
64d91a3
4e47631
d2258cf
27c86b3
bd2de27
ba2d6c9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: consider adding a special address (e.g.,
address(0)
) where the contract would execute the transaction to self. This is a neat optimization when you must batch multiple calls on the account contract itself.This is implemented in Safe's MultiSend contract: https://github.com/safe-global/safe-smart-account/blob/7f79aaf05c33df71d9cb687f0bc8a73fa39d25d5/contracts/libraries/MultiSend.sol#L50C17-L50C57