This repository has been archived by the owner on Jan 14, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 393
Create provenance.sol #24
Open
terzim
wants to merge
1
commit into
ethereum:master
Choose a base branch
from
terzim:patch-2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
// provenance concept contract created by M.ElBoudi, A.Blackwell, M.Terzi et al during Ethereum development workshop in London | ||
|
||
contract Certifiers { | ||
mapping (address => bool) certifier; | ||
address provenance; | ||
|
||
//initialiser is run the first time the contract is uploaded to the network. Launched by Provenance and reads provenance "public key" | ||
function Certifiers () { | ||
provenance = msg.sender; | ||
} | ||
|
||
function createNewCertifier() returns (bool completed) { | ||
certifier[msg.sender] = false; | ||
return true; | ||
} | ||
|
||
//if Provenance is launching the contract, then the entity becomes certified | ||
function certify(address targetCertifier) returns (bool completed) { | ||
if (provenance == msg.sender) { | ||
certifier[targetCertifier] = true; | ||
return true; | ||
} else { | ||
return false; | ||
} | ||
} | ||
} | ||
|
||
contract Producers{ | ||
struct meta{ | ||
bytes32 description; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is it important to have this structure (description, phoneNumber, name) inside the contract? You could just use a |
||
uint phoneNumber; | ||
bytes32 name; | ||
bool certified; | ||
} | ||
mapping (address => meta) producer; | ||
|
||
function createProducer(bytes32 desc, uint phone, bytes32 name) returns (bool created) { | ||
producer[msg.sender].description = desc; | ||
producer[msg.sender].phoneNumber = phone; | ||
producer[msg.sender].name = name; | ||
producer[msg.sender].certified = false; | ||
return true; | ||
} | ||
} | ||
|
||
contract producerList{ | ||
|
||
mapping (address => bytes32) producerList; | ||
|
||
function addProducer(bytes32 desc, uint phone, byte name) returns (bool completed) { | ||
var producers = new Producers(); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The address of the Producers is "lost" after the function returns. Is that intended? |
||
return producers.createProducer(desc, phone, name); | ||
|
||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if I understand this correctly. Every key exists in a mapping from the beginning and is initialised to "zero", e.g.
false
for abool
. So this is more likeresetCertify
, i.e. it only reverses the effect ofcertify
.