Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug report: wrong color combination for tags on stablecoins page #8923

Closed
konopkja opened this issue Dec 15, 2022 · 5 comments
Closed

Bug report: wrong color combination for tags on stablecoins page #8923

konopkja opened this issue Dec 15, 2022 · 5 comments
Assignees
@TylerAPfledderer
Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing

Comments

@konopkja
Copy link
Contributor

konopkja commented Dec 15, 2022 •
edited
Loading

Describe the bug

Stablecoins page contains a section where tags are used.

The color combinations have very low contrast and the text inside the tag is unreadable.

To reproduce

  1. Go to (https://ethereum.org/en/stablecoins/)
  2. Scroll down to the "How to get stablecoins" section
  3. See the color combination

Expected behavior

Contrasting colors so that text is readable.

Screenshot 2022-12-15 at 20 37 47

Screenshot 2022-12-15 at 20 38 00

Screenshots of current situation

Screenshot 2022-12-15 at 20 24 13

Screenshot 2022-12-15 at 20 24 28

Desktop (please complete the following information)

latest chrome, macbook

Smartphone (please complete the following information)

No response

Additional context

No response
@konopkja konopkja added bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing labels Dec 15, 2022
@TylerAPfledderer
Copy link
Contributor

@konopkja bug was introduced in #8774 (my mistake). I'll take this to make the correction!

This was referenced Dec 15, 2022
Closed
Closed
@uday03meh
Copy link

Hi, Can I start working on it?

@TylerAPfledderer
Copy link
Contributor

Hi, Can I start working on it?

Hey @uday03meh! I have already addressed this with the referenced PR above. 😄

@pettinarip
Copy link
Member

Nice, thanks @uday03meh & @TylerAPfledderer (I've assigned this to you)

@pettinarip
Copy link
Member

This is issue is fixed in #8601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TylerAPfledderer TylerAPfledderer

Labels
bug 🐛 Something isn't working good first issue Good item to try if you're new to contributing
Projects
None yet
Milestone
No milestone
4 participants
@pettinarip @uday03meh @TylerAPfledderer @konopkja