Fix: change color prop in pills to background in StablecoinAccordion
#8927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm and
jmcook1186
as code owners
TylerAPfledderer
changed the title
StablecoinAccordion): change color prop in pills to backgroundcolor prop in pills to background in StablecoinAccordion
✅ ethereum-org-website-dev deploy preview ready
|
|
Hey @TylerAPfledderer sorry for the late review on this but I think that, considering that we are refactoring the Pill component in #8601, there is no need to merge this. Feel free to disagree and re-open. |
github-actions
bot
added
the
abandoned
|
Nope that is good. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR #8774 a bug was introduced to the
StableAccordioncomponent where the pills were not rendering the text color correctly.This PR changes the
colorprop to theStyledPillinstances tobackgroundwhich was changed in thePillcomponent. This ensures that the background of theStyledPill's receives the passed in color and not the text.Related Issue
Closes: #8923