migrated: pages/developers/learning-tools.tsx to Chakra UI #10348
Conversation
Seek4samurai
requested review from
samajammin,
wackerow,
corwintines,
pettinarip,
minimalsm,
jmcook1186 and
nhsz
as code owners
✅ ethereum-org-website-dev deploy preview ready
|
There was a problem hiding this comment.
Hey @Seek4samurai, nice work on this 💪
I've Made some suggested tweaks to get this closer to the current design.
The main thing we need to solve is that we are setting some breakpoints the wrong way round (e.g. 0px margin on big screens and 8px on small, instead of the opposite). I've left suggestions that I believe fixes all of these 🫡
| const Subtitle = (props: ChildOnlyProp) => ( | ||
| <Flex | ||
| fontSize={"xl"} | ||
| lineHeight={"short"} |
There was a problem hiding this comment.
Just noting, this is a tiny bit different from what we have currently. Not sure if we care about this @pettinarip?
There was a problem hiding this comment.
Yea, we want to keep the current styles so this should be lineHeight={1.4}
There was a problem hiding this comment.
Hey @Seek4samurai, nice work on this 💪
I've Made some suggested tweaks to get this closer to the current design.
The main thing we need to solve is that we are setting some breakpoints the wrong way round (e.g. 0px margin on big screens and 8px on small, instead of the opposite). I've left suggestions that I believe fixes all of these 🫡
|
Ok maybe I did messed up some breakpoints. Thanks! |
Co-authored-by: Joshua <[email protected]>
There was a problem hiding this comment.
Thanks for the PR @Seek4samurai.
I've applied the suggestions from the reviews. This is good to go now 💪🏼
pettinarip
dismissed
minimalsm’s stale review
Suggestions were applied. Will merge it now. Feel free to add more comments if needed
Description
Migrated pages/developers/learning-tools.tsx to Chakra UI.
Related Issue
#9353