-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate info on pow-mining from ethdocs and eth.wiki #5897
Conversation
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 15m PerformanceLighthouse report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Found it very well put together and educational for me.
Comments are mostly around site conventions or some simplifications I think we could make, but I'll leave those up to you.
src/content/developers/docs/consensus-mechanisms/pow/mining/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmcook1186 🙏🏻 Thank you again for these. Great addition to fill out the background of PoW, appreciate your work on this. This seems super close.. bunch of code suggestions left, mostly non-controversial I feel.
Let me know if you want a hand tuning this up, we'll try to get this in soon =)
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash/index.md
Outdated
Show resolved
Hide resolved
...content/developers/docs/consensus-mechanisms/pow/mining-algorithms/dagger-hashamoto/index.md
Outdated
Show resolved
Hide resolved
...content/developers/docs/consensus-mechanisms/pow/mining-algorithms/dagger-hashamoto/index.md
Outdated
Show resolved
Hide resolved
...content/developers/docs/consensus-mechanisms/pow/mining-algorithms/dagger-hashamoto/index.md
Outdated
Show resolved
Hide resolved
...content/developers/docs/consensus-mechanisms/pow/mining-algorithms/dagger-hashamoto/index.md
Outdated
Show resolved
Hide resolved
...content/developers/docs/consensus-mechanisms/pow/mining-algorithms/dagger-hashamoto/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Joshua <[email protected]> Co-authored-by: Paul Wackerow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪🏻 Thanks again @jmcook1186!
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining/index.md
Outdated
Show resolved
Hide resolved
…gorithms/index.md Co-authored-by: Marius van der Wijden <[email protected]>
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/index.md
Outdated
Show resolved
Hide resolved
…gorithms/index.md Co-authored-by: Tim Beiko <[email protected]>
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/ethash/index.md
Outdated
Show resolved
Hide resolved
src/content/developers/docs/consensus-mechanisms/pow/mining-algorithms/index.md
Show resolved
Hide resolved
...content/developers/docs/consensus-mechanisms/pow/mining-algorithms/dagger-hashamoto/index.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Pushed some commits to add further reading section to each page. Merging now 🚀
Some low priority things we should tidy up at some point:
- Memory hard - should we explain what this means? (I’ve added a link out to wikipedia for now)
- Appendix - We should link to appendix using footnotes (see NFT page for example of this on site)
- EthHash page needs prerequisites
- UI bug introduced in our developer docs sidenav by the depth (I will create an issue)
Dagger Hashamoto page
“## More efficient cache-based evaluation algorithm {#cache-based-evaluation}” section
- Providing a sentence for context here would be good
Description
This PR aims to migrate information from the ethdocs.org and eth.wiki sites to appropriate pages on ethereum.org so that the information is preserved when those websites are deprecated.
To this end, I have done the following:
/mining-algorithms
, beneath/consensus-mechanisms/pow
/mining-algorithms
:/dagger-hashamoto
andethash
dagger-hashamoto/index.md
andethhash/index.md
Related Issue
This resolves suggested PR 12 from #5690 and PR 3 from #5731