Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate Ethereum history page from ethdocs.org #5935

Closed
wants to merge 8 commits into from
Closed

migrate Ethereum history page from ethdocs.org #5935

wants to merge 8 commits into from

Conversation

jmcook1186
Copy link
Contributor

@jmcook1186 jmcook1186 commented Apr 7, 2022

Description

Ethereum history from inception to first production network (homestead) is added to the history page on ethereum.org. The text is migrated from ethdocs.org with only minor typographic changes. Removed/updated dead links.

Also embedded image of Vitalik's announcement of Ethereum genesis on bitcointalk.org.

UPDATE: Added "design rationale" page to this PR. This is a direct, unedited transfer of information from wiki -> ethereum.org. I feel the page needs preserving but does not fit well on ethereum.org right now. I've migrated it into /history/design-rationale.

Related Issue

#5731

@gatsby-cloud
Copy link

gatsby-cloud bot commented Apr 7, 2022

Gatsby Cloud Build Report

🚩 Your build failed. See the build logs here

@minimalsm
Copy link
Contributor

Hey @jmcook1186,

I support adding these details, but I think we have a separation of concerns problem here. I believe the best approach is to separate these into two pages:

  1. the history of Ethereum (i.e. a story-driven narrative)
  2. the network upgrades history (i.e. the current history page)

There will obviously be some crossover with this approach, but I think this is best when we consider the discussion we had around fleshing out this story-driven narrative and translating it to provide a free, approachable resource for all to learn Ethereum's story so far.

What do you think?

Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmcook1186 Loving these PR's of yours, great work! I like the new breakdown where the story is separated a bit from the strict upgrade timeline.

Need to get an easier link to jump to the /network-upgrades/ subpage. Otherwise left a handful of small semantic adjustments, and suggestions on removing some dead links from the design rationale page.
After that I think this is good to go =)

src/content/history/index.md Outdated Show resolved Hide resolved
src/content/history/index.md Outdated Show resolved Hide resolved
src/content/history/index.md Outdated Show resolved Hide resolved
src/content/history/index.md Outdated Show resolved Hide resolved
src/content/history/index.md Outdated Show resolved Hide resolved
src/content/history/design-rationale/index.md Outdated Show resolved Hide resolved
src/content/history/design-rationale/index.md Outdated Show resolved Hide resolved
src/content/history/design-rationale/index.md Outdated Show resolved Hide resolved
src/content/history/design-rationale/index.md Outdated Show resolved Hide resolved
src/content/history/design-rationale/index.md Outdated Show resolved Hide resolved
@minimalsm
Copy link
Contributor

@jmcook1186 I've moved the network upgrade's timeline back to (/history/) and moved the new page to (/history/story-of-ethereum/) for now. We link out to /history/ a lot across the site which would break those links and we'd also have to change translated versions of ethereum.org to match, as well as update our translation management software mid update, which might confuse our reviewers.

Support the change of structure overall, but let's get the content in first and change the architecture when the timing is more optimal.

@minimalsm
Copy link
Contributor

Closing for now until we get a better sense of what we want to do here and if we want to do it.

@minimalsm minimalsm closed this May 12, 2022
@github-actions github-actions bot added the abandoned This has been abandoned or will not be implemented label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned This has been abandoned or will not be implemented content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants