-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Find wallet revamp #6457
Merged
+5,025
−964
Merged
Find wallet revamp #6457
Changes from 1 commit
Commits
Show all changes
250 commits
Select commit
Hold shift + click to select a range
eed93be
initial commit to clean slate
corwintines a8e5345
feat: new header
corwintines 361154f
filter tabs
corwintines 34d7fcf
Merge branch 'dev' into find-wallet-revamp
corwintines 248ee26
tabs and starting personas
corwintines df4a0fa
wip
corwintines 34e1086
add preset filter functionality to user personas
corwintines e0cb000
WalletFilterSidebar progress
corwintines b27bd95
WalletFilterSidebar input functionality and styling
corwintines 19d7f88
WalletFilterSidebar filters
corwintines e5ce3b7
note
corwintines e60253c
styles
corwintines 17585a0
setup dumby data
corwintines 4c3b838
wip
corwintines d8ab6bd
Merge branch 'dev' into find-wallet-revamp
corwintines 8bcbf67
dropdowns
corwintines ee50560
wip
corwintines 05968f8
styling icons
corwintines 448be0e
icons
corwintines ddb70e9
device labels
corwintines bd0f036
remove console.log
corwintines b0024fd
more info functionality
corwintines cc37a72
basic filter setup, needs to be flushed out for all features
corwintines 9028f41
more info categories
corwintines 929ca7a
wallet filter
corwintines d68186a
more info line
corwintines b6da8de
feature icons more info
corwintines 1b20172
persona labels
corwintines e8b6897
socials
corwintines f01ec95
responsive to 1024px
corwintines b4cdb93
wallet table mobile
corwintines 2ddfcd6
styling bug
corwintines 42fb40c
make more of wallet row clickable for more info
corwintines 9b83926
device toggle
corwintines 4ade36e
functionality for sidebar
corwintines 21e14d6
styling filter mobile button
corwintines 376281c
new exported icons
nloureiro 711233e
Hardware icon update
nloureiro 459792a
side bar filters css details
nloureiro 10fe189
personas tab css details
nloureiro c16a444
Merge branch 'dev' into find-wallet-revamp
corwintines 343d311
wallet survey
corwintines 1ed7b17
WalletConnect icon
nloureiro 9fa12e9
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
nloureiro 5fc2c66
Connect Dapp icon
nloureiro 629c99c
WithdrawCrypto icon
nloureiro e64536f
new hero image
nloureiro 2b2d314
Multisig icon added and twiq the Withdraw icon
nloureiro d77c5f3
social recovery icon and icons adjustmens
nloureiro 7171747
fix z-index issue for wallet icons, and add svg to dropdown options
corwintines bb7f811
add icon to feature filter dropdown
corwintines 6f28d47
fix header on mobile
corwintines 34f9ca3
fix mobile dropdowns
corwintines 6f5f7ca
Swap Token icon
nloureiro 882cea6
sticky filter toggle
corwintines a2cdf03
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
corwintines a7ab112
various css adjustments
nloureiro 0066d2e
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
nloureiro 74ee458
small color detail
nloureiro 1e5a26d
Table details view adjustments
nloureiro c22f370
feature filters CSS spacings
nloureiro 7370e01
Add real wallet data file
minimalsm 62a7dc5
Add keystone
minimalsm 5043cc8
Add numio
minimalsm f90b947
Add coin98
minimalsm 10461a8
Add loopring
minimalsm 446d454
Add airgap
minimalsm 854b703
Add argent
minimalsm fb1fa1d
Add portis
minimalsm 0abf666
Add metamask
minimalsm a259d95
Add coinbase wallet
minimalsm d4f8951
Add frame
minimalsm 7869bd2
Add brave
corwintines 0e692b3
Add tally ho
corwintines fcd9686
Personas box with a bit less vertical space
nloureiro 69e2126
remove the icons on the table dropdowns
nloureiro 5527f4f
table dropdown spacing adjustments
nloureiro c0dd1ea
line height design bug fixed
nloureiro f5df9d5
syntax fix, add default values back in for feature comparison dropdowns
corwintines 8dd946f
remove unused code
corwintines 991659c
filter out selected feature comparisons so user cant select multiple …
corwintines 029f11e
increase clickable area for checkbox and toggles
corwintines 1c4ea05
remove search funcitonality from feature compare dropdowns
corwintines 6b41fa6
deselect user persona function
corwintines 08421f7
persistent personas, and reset filter functionality
corwintines 3063b85
reset button and tabs styling
nloureiro bdc9097
link to wallet on table styling
nloureiro 5868c49
table header retouched
nloureiro c204982
not primary color on dropdowns
nloureiro 1340421
Update src/components/FindWallet/WalletFilterSidebar.tsx
corwintines e2118ee
Update src/components/FindWallet/WalletFilterSidebar.tsx
corwintines c553872
Merge branch 'dev' into find-wallet-revamp
corwintines 1344c6a
Switch to using real data instead of dummy data
corwintines ecdb08f
add typing to wallet-data.ts
corwintines 943eaf4
add hover effect for user profiles
corwintines 38bf88a
color styles for selected and hover user profile
corwintines f05ea52
show wallet text bold, color change, and copy change
corwintines 27fedaf
untoggle if all checkboxes become unchecked
corwintines f0f3b98
update compare icons
corwintines 139945c
toggle persistence
corwintines a3c8248
border bottom headers filter panels
corwintines 850529e
fix brand color data
corwintines 35bb81f
full width mobile styling table and filters
corwintines e915250
bring back the border
nloureiro 877f1f5
Add gnosis safe
minimalsm 06c3c52
Comment out note causing ts error
minimalsm 0bd07e3
Add coinwallet
minimalsm d02a01b
Add ambire
minimalsm 383dde4
Add wallet images to gql query
minimalsm 7d68715
transitions
nloureiro 8467f73
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
nloureiro 645eab0
remove dedicated_support key in favor of socials
corwintines 7858f59
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
corwintines 0a4658f
update loopring value based on feedback
corwintines 8ea097c
change airgap layer 2 based on feedback
corwintines 95e43bc
update argent browser extension
corwintines 86ed138
spam_protection -> scam_protection
corwintines f29523e
Merge branch 'dev' into find-wallet-revamp
corwintines 162001b
update more info layout
corwintines 81536ce
add last updated information
corwintines 4df4b1e
randomize list order on page load
corwintines ff97171
Remove dedicated support
minimalsm 222c8a9
Add zengo
minimalsm 9721f86
Add linen
minimalsm 78d07c7
reset button
nloureiro 5fdcf76
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
nloureiro a24a7f0
filters and personas styling
nloureiro e0c6f8b
messing the theme colors in the filters
nloureiro 8d1e110
colors adjustments for the personas
nloureiro b329257
filter styles are done
nloureiro 12d3dbd
Merge branch 'dev' into find-wallet-revamp
corwintines f734374
dropdown colors
corwintines 5f6309b
temp styles for mobile tab
corwintines 886d0cd
convert WalletTable to use table
corwintines be8552a
full width table
corwintines ea02b74
sticky fixes
corwintines c891897
mobile styling
corwintines 47aa5af
preset compare filters
corwintines 2afcd20
wallet details styling
nloureiro ab93024
reset filter button 100% wide
nloureiro 316169a
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
minimalsm ed06589
Add imtoken
minimalsm 6a28f5b
Add 1inch / replace old 1inch logo
minimalsm c87a63b
wallet table adjustments
nloureiro cb2c459
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
nloureiro 3e13709
Add foxwallet
minimalsm 5ad3427
Add mycrypto
minimalsm 7a6da2c
last small details on the table
nloureiro 0272db4
Table header styles
nloureiro d3e32c7
Add pillar
minimalsm 68dd080
Add MEW mobile
minimalsm 91cfd85
small spacing in the table
nloureiro 13fa4df
wallet name in bold
nloureiro 7c145c0
Add unstoppable
minimalsm 4c1e9f2
Add myetherwallet
minimalsm ad53302
Add alpha
minimalsm 577b7dd
Add opera
minimalsm 990a435
Add guarda
minimalsm 1ef5377
Add web3auth
minimalsm a9cd319
Add bridge wallet
minimalsm f3d3520
Add torus
minimalsm 4eb439b
Add tokenpocket
minimalsm d08d356
add a helper microcopy to the personas tab
nloureiro 1f55eba
Add image imports on find-wallet
minimalsm e5eb52c
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
minimalsm 6a5ce10
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
minimalsm e75f196
remove the primary color
nloureiro a04563a
eip1559 icon ready to be pulled in
nloureiro 97c3413
nem ENS icon
nloureiro e6d315e
add padding left to wallet logo in the table
nloureiro 59b8bc6
Merge branch 'dev' into find-wallet-revamp
corwintines 5ec2d68
overflows
corwintines 78c91f7
features stacked in mobile
corwintines 17b4049
fixed icon container height and width
corwintines 5a0dfcf
choose to compare filter header
corwintines b2c9cdd
mobile sticky styling
corwintines d293001
update persona filters
corwintines 286c9dd
add eip-1559 and swaps features
corwintines 9380a43
add feature count to feature filter tab
corwintines 92e9314
Merge branch 'dev' into find-wallet-revamp
corwintines f5c44d5
add find-wallet to useSurvey hook
corwintines 53f3ee8
refactor for tooltips
corwintines 911bd40
OR logic for devices
corwintines e48ad81
close icon for mobiel filter panel
corwintines 1ae2a32
remove pipes for mobile view of device labels
corwintines 8c89d93
copy pass and typescript pass
corwintines 13010d7
feature details styling and tooltip smaller
nloureiro 661c097
mobile filters over the list
nloureiro d83156d
Remove alt from hero
minimalsm cdc1982
fixing the mobile filter button
nloureiro 50a7928
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
nloureiro 15ae520
resolved conflict
nloureiro 6ce6456
Reset filters a11y button
minimalsm 1965df9
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
minimalsm 647550c
Remove misused heading from profile filter prompt and rename
minimalsm 552673e
Fix a11y personas
minimalsm 962d398
User "projects" not "companies"
samajammin 440c728
Feature filters a11y
minimalsm c8fc47f
Remove unused h4 styles
minimalsm ef47291
Remove hero again
minimalsm 3312821
small styling of the table list
nloureiro da4c6e6
fix the dancing pixel on the dropdowns
nloureiro 1f0e2d1
Merge pull request #6858 from ethereum/wallet-projects
minimalsm 3c788c1
change width of filters and list
nloureiro 1d029ba
add button to wallet website bellow features
nloureiro 6ddfbac
remove im from personas, and position NFT as second user persona
corwintines ca98c2d
1inch wallet icon
corwintines 6b322a1
line-through on the off features
nloureiro a43c6e3
move the tootip icon closer to text
nloureiro ce9c007
changed selected colors to default and align checkbox
nloureiro 1eb9f58
fix line through on tooltips
nloureiro 8ad7f77
Update WalletTable.tsx
nloureiro 3a6b040
"go to wallet" button opacity
nloureiro 6571832
matomo events
corwintines 7cc0d34
fix or logic
corwintines d99d094
box shadow for the mobile over the content filters
nloureiro 1995011
mobile filters toggle button final touches
nloureiro 7029c9f
new X and V svg icons
nloureiro a311cab
let's try to make the scroll-bar less ugly
nloureiro 0d4378d
Sort wallet features
minimalsm da2188c
Add key and fix wallet filtering
minimalsm 825c28e
Update src/pages/wallets/find-wallet.tsx
minimalsm f330667
Update TallyHo image
minimalsm a4b0a3f
Update Frame wallet image
minimalsm 3778929
Update Ambire wallet image
minimalsm 04fe0ae
Add break to optimise loop
minimalsm 74c2351
Add rainboe wallet
minimalsm e534782
Add Status wallet
minimalsm 4090c71
Add Rainbow and status to gql query
minimalsm cf2552c
Add aktionariat wallet
minimalsm 116dfcc
Remove device filters from new to crypto persona
minimalsm 6822303
Fix typo in NFTs
minimalsm 73f8e74
Remove device filters from new to developer persona
minimalsm 1b7ea92
Remove open source as requirement from developer persona
minimalsm 0696b98
Improve number of wallets showing message
minimalsm 2689ccc
Update copy updates to feature filters
minimalsm 2ba3490
Update showing all wallets
minimalsm 6c3d413
Merge branch 'find-wallet-revamp' into sortWalletFeatures
minimalsm 5f6285c
Make frame image background transparent
minimalsm c3aef08
Make MetaMask opensource
minimalsm a3ba547
feature compare dropdown default values
corwintines 91c4ba1
fix black overlay size
nloureiro 262cb98
ButtonLink component instead of Link
corwintines 90e7f64
Merge branch 'find-wallet-revamp' of https://github.com/ethereum/ethe…
corwintines 10261f2
change opacity for scale in the social links
nloureiro e7d40fe
Update src/data/wallets/wallet-data.ts
minimalsm 7a4ec90
Update src/components/FindWallet/WalletPersonasSidebar.tsx
corwintines f75d8d8
whole row clickable to expand
corwintines 57b0887
Merge branch 'find-wallet-revamp' into sortWalletFeatures
corwintines 95a5857
Merge pull request #6870 from ethereum/sortWalletFeatures
corwintines File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
add preset filter functionality to user personas
- v9.4.1
- v9.4.0
- v9.3.0
- v9.2.1
- v9.2.0
- v9.1.0
- v9.0.1
- v9.0.0
- v8.10.1
- v8.10.0
- v8.9.0
- v8.8.0
- v8.7.1
- v8.7.0
- v8.6.0
- v8.5.2
- v8.5.1
- v8.5.0
- v8.4.0
- v8.3.0
- v8.2.0
- v8.1.1
- v8.1.0
- v8.0.2
- v8.0.1
- v8.0.0
- v7.24.5
- v7.24.4
- v7.24.3
- v7.24.2
- v7.24.1
- v7.24.0
- v7.23.1
- v7.23.0
- v7.22.4
- v7.22.3
- v7.22.2
- v7.22.1
- v7.22.0
- v7.21.0
- v7.20.1
- v7.20.0
- v7.19.2
- v7.19.1
- v7.19.0
- v7.18.0
- v7.17.2
- v7.17.1
- v7.17.0
- v7.16.0
- v7.15.0
- v7.14.2
- v7.14.1
- v7.14.0
- v7.13.1
- v7.13.0
- v7.12.4
- v7.12.3
- v7.12.2
- v7.12.1
- v7.12.0
- v7.11.4
- v7.11.3
- v7.11.2
- v7.11.1
- v7.11.0
- v7.10.1
- v7.10.0
- v7.9.2
- v7.9.1
- v7.9.0
- v7.8.0
- v7.7.3
- v7.7.2
- v7.7.1
- v7.7.0
- v7.6.1
- v7.6.0
- v7.5.1
- v7.5.0
- v7.4.1
- v7.4.0
- v7.3.3
- v7.3.2
- v7.3.1
- v7.3.0
- v7.2.0
- v7.1.0
- v7.0.0
- v6.16.0
- v6.15.3
- v6.15.2
- v6.15.1
- v6.15.0
- v6.14.3
- v6.14.2
- v6.14.1
- v6.14.0
- v6.13.1
- v6.13.0
- v6.12.1
- v6.12.0
- v6.11.0
- v6.10.2
- v6.10.1
- v6.10.0
- v6.9.4
- v6.9.3
- v6.9.2
- v6.9.1
- v6.9.0
- v6.8.2
- v6.8.1
- v6.8.0
- v6.7.6
- v6.7.5
- v6.7.4
- v6.7.3
- v6.7.2
- v6.7.1
- v6.7.0
- v6.6.1
- v6.6.0
- v6.5.0
- v6.4.2
- v6.4.1
- v6.4.0
- v6.3.0
- v6.2.0
- v6.1.0
- v6.0.0
- v5.4.0
- v5.3.1
- v5.3.0
- v5.2.0
- v5.1.2
- v5.1.1
- v5.1.0
- v5.0.0
- v4.11.1
- v4.11.0
- v4.10.0
- v4.9.0
- v4.8.0
- v4.7.0
- v4.6.0
- v4.5.0
- v4.4.0
- v1.0
commit 34e10867ec5e9702eb0001d90e16a57e4d6792b3
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't allow a user to deselect an active persona - we should support that.
Currently the only way to deselect a persona once it's been selected it to click on a different one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. it was a design bug. I had it in the first drafts and somehow disappear form the final proposal.
The idea is something like this