Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS migration - /pages-conditional #6486

Merged
merged 11 commits into from
Jun 7, 2022
Merged

TS migration - /pages-conditional #6486

merged 11 commits into from
Jun 7, 2022

Conversation

pettinarip
Copy link
Member

@pettinarip pettinarip commented May 27, 2022

Description

  • Migrated /pages-conditional files.
  • Refactored how we pull our wallets images from graphql

Related Issue

#6392

@samajammin
Copy link
Member

@pettinarip could you explain a bit about the new /schema/ directory?

Is this where we should now define the schema of any /src/data/ file? What are sdls vs. builders? Should we have documentation around this moving forward?

src/components/Link.tsx Outdated Show resolved Hide resolved
Base automatically changed from ts-templates to dev June 2, 2022 23:40
Copy link
Member

@wackerow wackerow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this originally targeting the branch from #6479? I see the base automatically switched over to dev from somewhere else, so no preview deploy*.

#6479 is now merged into dev, and I updated this branch with latest from dev. Locally this is building great for me. All the wallet images are working correctly, bounty board looks good, no errors when spot checking other pages.

  • Update: Looks like merging in dev changes triggered a build. Will check that and merge if good.

src/schema/builders/WalletsCsv.ts Show resolved Hide resolved
@samajammin
Copy link
Member

Was this originally targeting the branch from #6479? I see the base automatically switched over to dev from somewhere else

Yes, nice GH feature 😄

@gatsby-cloud
Copy link

gatsby-cloud bot commented Jun 3, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 29m

Performance

Lighthouse report

Metric Score
Performance 🔶 20
Accessibility 💚 91
Best Practices 💚 100
SEO 💚 92

🔗 View full report

@pettinarip
Copy link
Member Author

@pettinarip could you explain a bit about the new /schema/ directory?

There was a lack of explanation in my PR. My bad.

I tried to organize a bit how we are defining our schema in the createSchemaCustomization hook. I moved all of what was there to the new /schema folder.

There are two ways to define a schema in Gatsby (I believe):

That is why you see two folders in /schema

  • sdls
  • builders

@pettinarip
Copy link
Member Author

Was this originally targeting the branch from #6479? I see the base automatically switched over to dev from somewhere else, so no preview deploy*.

Thanks @wackerow. Yes, it was targeting that branch.

Copy link
Member

@samajammin samajammin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Looks great overall, just a few comments, mainly to:

  • fix typos
  • add a /docs page to explain the new schema dirctory

@pettinarip pettinarip merged commit 3fdb14f into dev Jun 7, 2022
@pettinarip pettinarip deleted the ts-pages-conditional branch June 7, 2022 20:56
@minimalsm minimalsm mentioned this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants