-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TS migration - /pages-conditional #6486
Conversation
@pettinarip could you explain a bit about the new /schema/ directory? Is this where we should now define the schema of any /src/data/ file? What are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this originally targeting the branch from #6479? I see the base automatically switched over to dev from somewhere else, so no preview deploy*.
#6479 is now merged into dev, and I updated this branch with latest from dev. Locally this is building great for me. All the wallet images are working correctly, bounty board looks good, no errors when spot checking other pages.
- Update: Looks like merging in dev changes triggered a build. Will check that and merge if good.
Yes, nice GH feature 😄 |
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 29m PerformanceLighthouse report
|
There was a lack of explanation in my PR. My bad. I tried to organize a bit how we are defining our schema in the There are two ways to define a schema in Gatsby (I believe):
That is why you see two folders in
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work! Looks great overall, just a few comments, mainly to:
- fix typos
- add a
/docs
page to explain the new schema dirctory
Co-authored-by: Sam Richards <[email protected]>
Co-authored-by: Sam Richards <[email protected]>
Description
/pages-conditional
files.Related Issue
#6392