Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Card component to TS #6487

Merged
merged 2 commits into from
May 30, 2022
Merged

Conversation

minimalsm
Copy link
Contributor

Description

  • Migrates Card component to Typescript
  • I was going to migrate all Cards that extend it but it looks like all of our cards are standalone components 🤔

Related Issue

#6392

Copy link
Member

@pettinarip pettinarip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 💪🏼 added a small comment there

src/components/Card.tsx Outdated Show resolved Hide resolved
@pettinarip
Copy link
Member

  • I was going to migrate all Cards that extend it but it looks like all of our cards are standalone components thinking

Uhmm yes, something to improve perhaps 👍🏼 to compose them better and reuse code.

Co-authored-by: Pablo Pettinari <[email protected]>
@gatsby-cloud
Copy link

gatsby-cloud bot commented May 27, 2022

Gatsby Cloud Build Report

ethereum-org-website-dev

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 12m

Performance

Lighthouse report

Metric Score
Performance 🔶 21
Accessibility 💚 100
Best Practices 💚 100
SEO 💚 92

🔗 View full report

@pettinarip pettinarip merged commit 162a195 into dev May 30, 2022
@pettinarip pettinarip deleted the migrateCardComponentToTypeScript branch May 30, 2022 18:06
@wackerow wackerow mentioned this pull request Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants