migrate YouTube component to Typescript #6499
Conversation
motemotech
requested review from
samajammin,
wackerow,
corwintines,
pettinarip and
minimalsm
as code owners
Gatsby Cloud Build Reportethereum-org-website-dev 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 13m PerformanceLighthouse report
|
There was a problem hiding this comment.
Hey @motemotech, thanks for the PR 💪😎
We should add type checks on the props here using an interface and explicitly declare what the function returns (a React functional component)
e.g.
export interface IProps {
// props and types go here
}const YouTube: (ADD A RETURN TYPE HERE) = ({ id, start = "0", title }) => {
...
}
|
Hi! Thank you @minimalsm !! |
|
@motemotech here's some documentation on this: https://github.com/ethereum/ethereum-org-website/blob/dev/docs/typescript.md |
|
@samajammin |
|
I've just changed my code. |
There was a problem hiding this comment.
Hey @motemotech, the start prop should be optional as we only pass it when we want a YouTube video to start AFTER 0 seconds.
src/components/YouTube.tsx
Outdated
|
|
||
| export interface IProps { | ||
| id: string | ||
| start: string |
There was a problem hiding this comment.
The start prop should be optional here.
There was a problem hiding this comment.
Is this correct?
start?: string
There was a problem hiding this comment.
@motemotech I just pushed a commit to make start and title as optional, and I gave them a default value.
|
@all-contributors please add @motemotech for code |
|
I've put up a pull request to add @motemotech! 🎉 |
|
@motemotech be sure to join the discord if you are interested in contributing further to the project or have any questions for the team. And we've just released our 2022 POAPs so remember to claim yours also 🥳! |
|
I'm Nico! I already joined the discord! |
Description
Related Issue
#6392